Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/backend/base/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ dependencies = [
'elevenlabs==1.58.1; python_version == "3.12"',
'elevenlabs>=1.52.0,<2.0.0; python_version != "3.12"',
"scipy>=1.15.2,<2.0.0",
"ibm-watsonx-ai>=1.3.1,<2.0.0; python_version < '3.14'",
"langchain-ibm~=1.0.2; python_version < '3.14'",
"ibm-watsonx-ai>=1.3.1,<2.0.0",
"langchain-ibm~=1.1.0",
Comment on lines +99 to +100

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Check for stale 3.14-gating assumptions in tests/docs.
rg -n -C2 "python_version<'3\\.14'|Python 3\\.14\\+|not available on Python 3\\.14|upstream pins exclude 3\\.14|pytest\\.skip\\(" \
  src/backend/tests/unit/base/models/test_model_utils.py \
  src/bundles/ibm/tests/test_watsonx_embeddings.py \
  src/bundles/ibm/README.md

# Confirm base and bundle Watsonx constraints are still aligned.
rg -n -C1 "\"ibm-watsonx-ai|langchain-ibm" \
  src/backend/base/pyproject.toml \
  src/bundles/ibm/pyproject.toml

Repository: langflow-ai/langflow

Length of output: 2720


Fix lingering Python 3.14 “upstream gated” skips in IBM Watsonx tests

  • src/backend/tests/unit/base/models/test_model_utils.py:12-17 and src/bundles/ibm/tests/test_watsonx_embeddings.py:11-14 still pytest.skip(..., allow_module_level=True) on ImportError with comments referencing python_version<'3.14' gating; this can mask real 3.14 importability regressions.
  • Update these tests to assert the newly supported 3.14 import path (and remove/adjust the outdated gating rationale/skip logic) in line with the dependency pins in src/backend/base/pyproject.toml:99-100.
  • Ensure src/bundles/ibm/README.md:29-38 also no longer documents the old <3.14 gating behavior.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/backend/base/pyproject.toml` around lines 99 - 100, Tests currently skip
on ImportError with legacy python_version<'3.14' gating which can hide real
import regressions; update the two test modules (test_model_utils.py and
test_watsonx_embeddings.py) to remove the pytest.skip(...,
allow_module_level=True) import-based skip and instead directly import/assert
the IBM Watsonx client/package import path that should now succeed per the
pinned deps ("ibm-watsonx-ai" and "langchain-ibm"); remove or update the inline
comments referencing "<3.14" gating and replace with a simple import/assert
check (or an explicit failure message) so failures surface, and similarly edit
the IBM bundle README section describing `<3.14` gating to reflect the new
supported 3.14 importability.

"trustcall>=0.0.38,<1.0.0",
"langchain-chroma~=0.2.6",
"jaraco-context>=6.1.0",
Expand Down
12 changes: 8 additions & 4 deletions src/bundles/ibm/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,19 @@ keywords = ["langflow", "lfx", "extension", "bundle", "ibm", "db2", "watsonx", "
# wheel does not ship for linux/aarch64, so the dep would otherwise
# break ``pip install`` on that arch.
# * ``ibm-watsonx-ai`` and ``langchain-ibm`` power ``WatsonxAIComponent``
# and ``WatsonxEmbeddingsComponent``. Both upstreams pin ``<3.14``, so
# the marker stays in lockstep with the langflow-base dep block.
# and ``WatsonxEmbeddingsComponent``. Both upstreams added Python 3.14
# support (``ibm-watsonx-ai`` 1.5.13, ``langchain-ibm`` 1.1.0), so the
# former ``python_version < '3.14'`` markers are lifted. ``ibm-watsonx-ai``
# raised its floor to ``>=3.11`` on the 3.14-capable build, so the universal
# resolver forks: a 3.14 build on the 3.14 Docker image, an older
# 3.10-compatible build elsewhere. Kept in lockstep with langflow-base.
# * ``langchain-community`` provides the helpers DB2VS leans on.
dependencies = [
"lfx>=0.5.0",
"langchain-community>=0.4.1,<1.0.0",
"ibm-db>=3.2.9,<4.0.0; sys_platform != 'linux' or platform_machine != 'aarch64'",
"ibm-watsonx-ai>=1.3.1,<2.0.0; python_version < '3.14'",
"langchain-ibm~=1.0.2; python_version < '3.14'",
"ibm-watsonx-ai>=1.3.1,<2.0.0",
"langchain-ibm~=1.1.0",
]

[project.urls]
Expand Down
Loading
Loading