-
Notifications
You must be signed in to change notification settings - Fork 9.7k
feat: a11y #13561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: a11y #13561
Changes from 29 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
e688e94
chore: add accessibility action plan and gap report for IBM Level 1 c…
viktoravelino 2ffd2d1
Merge branch 'release-1.10.0' into feat/a11y
viktoravelino fa7d541
feat: integrate accessibility checker for automated a11y scans
viktoravelino c9d45fa
feat: add accessibility test usage documentation for IBM scans
viktoravelino f188b5b
feat: enhance accessibility testing with JSON report aggregation and …
viktoravelino 170acde
feat: add GitHub Actions workflow for IBM accessibility scans
viktoravelino 6d5ef55
feat: update a11y scan workflow to allow testing from feat/a11y branch
viktoravelino db8da2a
Merge branch 'release-1.10.0' into feat/a11y
viktoravelino cd9ab69
feat: skip Puppeteer download during npm install in Dockerfiles for a…
viktoravelino 66318cf
Merge branch 'feat/a11y' of github.com:langflow-ai/langflow into feat…
viktoravelino 583afd0
Merge branch 'release-1.11.0' into feat/a11y
viktoravelino d76e217
feat: enhance a11y scan workflow to resolve and scan latest release b…
viktoravelino 9dbde72
Merge branch 'release-1.11.0' into feat/a11y
viktoravelino 3c1b2cd
test: add component a11y unit tests (jest-axe) (#13613)
viktoravelino 287ca4c
Merge branch 'release-1.11.0' into feat/a11y
viktoravelino 0007f20
feat: Add a11y regression scan suite (#13663)
viktoravelino caad567
Merge branch 'release-1.11.0' into feat/a11y
viktoravelino 5992048
Merge branch 'release-1.11.0' into feat/a11y
viktoravelino d82723e
Merge branch 'release-1.11.0' into feat/a11y
viktoravelino c49a8db
Merge branch 'release-1.11.0' into feat/a11y
viktoravelino c368ade
fix(a11y): restore focus-visible indicators (#13664)
olayinkaadelakun d36083e
a11y: improve auth accessibility coverage (#13724)
viktoravelino 6fae209
fix(a11y): add accessible names and hide decorative icons in Langflow…
olayinkaadelakun 5ea9fe6
Merge branch 'release-1.11.0' into feat/a11y
viktoravelino 6f7c1f8
fix(a11y): add accessible names to icon-only buttons, fix placeholder…
olayinkaadelakun f54bbbd
Merge remote-tracking branch 'origin/release-1.11.0' into feat/a11y
viktoravelino df4857f
fix: update package dependencies and versions in package-lock.json
viktoravelino 168054d
chore: Remove accessibility documentation and reports
viktoravelino 5eaf6f9
Merge branch 'release-1.11.0' into feat/a11y
viktoravelino ab5b9d9
chore: Add accessibility scan reports (#13812)
viktoravelino 04c861f
fix: update Playwright version to 1.60.0 and enhance a11y scan options
viktoravelino b2432ab
fix(test): keep fixture args destructured
viktoravelino adb1446
Merge branch 'release-1.11.0' into feat/a11y
viktoravelino 28bb7a8
test(a11y): bootstrap asset route scans
viktoravelino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,155 @@ | ||
| name: A11y / IBM Equal Access Scans | ||
|
|
||
| on: | ||
| pull_request: | ||
| schedule: | ||
| # Run nightly at 02:00 UTC, after the nightly build window | ||
| - cron: "0 2 * * *" | ||
| workflow_dispatch: | ||
| inputs: | ||
| ref: | ||
| description: "(Optional) ref to checkout" | ||
| required: false | ||
| type: string | ||
| assert: | ||
| description: "Fail the run when scans differ from committed baselines" | ||
| required: false | ||
| type: boolean | ||
| default: false | ||
|
|
||
| env: | ||
| NODE_VERSION: "22" | ||
| PYTHON_VERSION: "3.13" | ||
|
viktoravelino marked this conversation as resolved.
|
||
| # Define the directory where Playwright browsers will be installed. | ||
| # This path is used for caching across workflows | ||
| PLAYWRIGHT_BROWSERS_PATH: "ms-playwright" | ||
| PLAYWRIGHT_VERSION: "1.59.1" | ||
|
viktoravelino marked this conversation as resolved.
Outdated
|
||
|
|
||
| jobs: | ||
| a11y-scan: | ||
| name: Playwright scan runner | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| # Cron only fires from the default branch, so scheduled runs resolve the | ||
| # latest release-* branch and scan that (same pattern as nightly_build). | ||
| - name: Resolve Ref To Scan | ||
| id: resolve_ref | ||
| shell: bash | ||
| run: | | ||
| if [ -n "${{ inputs.ref }}" ]; then | ||
| REF="${{ inputs.ref }}" | ||
| elif [ "${{ github.event_name }}" = "schedule" ]; then | ||
| REF=$(git ls-remote --heads https://github.com/${{ github.repository }} 'refs/heads/release-*' \ | ||
| | awk '{print $2}' \ | ||
| | sed 's|refs/heads/||' \ | ||
| | grep -E '^release-[0-9]+\.[0-9]+\.[0-9]+$' \ | ||
| | sort -V \ | ||
| | tail -n 1) | ||
| if [ -z "$REF" ]; then | ||
| echo "No release-* branch found in ${{ github.repository }}" | ||
| exit 1 | ||
| fi | ||
| else | ||
| REF="${{ github.ref }}" | ||
| fi | ||
| echo "ref=$REF" >> "$GITHUB_OUTPUT" | ||
| echo "Scanning ref: $REF" | ||
|
|
||
| - name: Checkout Repository | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| ref: ${{ steps.resolve_ref.outputs.ref }} | ||
|
|
||
| - name: Setup Node.js Environment | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: ${{ env.NODE_VERSION }} | ||
|
|
||
| - name: Get npm cache directory | ||
| id: npm-cache-dir | ||
| shell: bash | ||
| run: echo "dir=$(npm config get cache)" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Cache npm dependencies | ||
| uses: actions/cache@v5 | ||
| continue-on-error: true | ||
| with: | ||
| path: ${{ steps.npm-cache-dir.outputs.dir }} | ||
| key: ${{ runner.os }}-npm-${{ env.NODE_VERSION }}-${{ hashFiles('src/frontend/package-lock.json') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-npm-${{ env.NODE_VERSION }}- | ||
|
|
||
| - name: Install Frontend Dependencies | ||
| run: npm ci | ||
| working-directory: ./src/frontend | ||
|
|
||
| - name: Cache Playwright Browsers | ||
| id: cache-playwright | ||
| uses: actions/cache@v5 | ||
| continue-on-error: true | ||
| with: | ||
| path: ${{ env.PLAYWRIGHT_BROWSERS_PATH }} | ||
| key: playwright-${{ env.PLAYWRIGHT_VERSION }}-chromium-${{ runner.os }} | ||
| restore-keys: | | ||
| playwright-${{ env.PLAYWRIGHT_VERSION }}-chromium-${{ runner.os }} | ||
|
|
||
| - name: Install Playwright Browser Dependencies | ||
| if: steps.cache-playwright.outputs.cache-hit != 'true' | ||
| shell: bash | ||
| run: | | ||
| cd ./src/frontend | ||
| npx playwright install --with-deps chromium | ||
|
|
||
| - name: "Setup Environment" | ||
| uses: astral-sh/setup-uv@v6 | ||
| with: | ||
| enable-cache: true | ||
| cache-dependency-glob: "uv.lock" | ||
| python-version: ${{ env.PYTHON_VERSION }} | ||
| prune-cache: false | ||
|
|
||
| - name: Install Python Dependencies | ||
| run: uv sync | ||
|
|
||
| - name: Run IBM Equal Access Scans | ||
| shell: bash | ||
| env: | ||
| RUN_A11Y: "true" | ||
| RUN_A11Y_ASSERT: ${{ github.event_name == 'workflow_dispatch' && inputs.assert && 'true' || 'false' }} | ||
| LANGFLOW_DEACTIVATE_TRACING: "true" | ||
| run: | | ||
| cd src/frontend | ||
| # Only specs that call runA11yScan produce reports; discover them | ||
| # so new scan hosts are picked up without editing this workflow. | ||
| SCAN_SPECS=$(grep -rl "runA11yScan(" tests --include="*.spec.ts" | sort) | ||
| echo "Specs with a11y scans:" | ||
| echo "$SCAN_SPECS" | ||
| test -n "$SCAN_SPECS" | ||
| npx playwright test $SCAN_SPECS --project=chromium --workers=1 --retries=2 | ||
|
|
||
| - name: Build IBM Scan Summary | ||
| if: always() | ||
| shell: bash | ||
| run: | | ||
| cd src/frontend | ||
| if ls coverage/accessibility-reports/*.json > /dev/null 2>&1; then | ||
| npm run a11y:report --silent | ||
| { | ||
| echo '```text' | ||
| npm run a11y:report --silent | ||
| echo '```' | ||
| } >> "$GITHUB_STEP_SUMMARY" | ||
| else | ||
| echo "No accessibility reports were generated." | tee -a "$GITHUB_STEP_SUMMARY" | ||
| fi | ||
|
|
||
| - name: Upload Accessibility Reports | ||
| if: always() | ||
| uses: actions/upload-artifact@v6 | ||
| with: | ||
| name: ibm-a11y-reports-${{ github.run_attempt }} | ||
| path: src/frontend/coverage/accessibility-reports | ||
| retention-days: 30 | ||
| overwrite: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| name: A11y / Component Unit Tests | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - "src/frontend/**" | ||
| - ".github/workflows/a11y-unit-tests.yml" | ||
| - "Makefile.frontend" | ||
| workflow_call: | ||
| inputs: | ||
| ref: | ||
| description: "(Optional) ref to checkout" | ||
| required: false | ||
| type: string | ||
| workflow_dispatch: | ||
| inputs: | ||
| ref: | ||
| description: "(Optional) ref to checkout" | ||
| required: false | ||
| type: string | ||
|
|
||
| env: | ||
| NODE_VERSION: "22" | ||
|
|
||
| jobs: | ||
| a11y-unit-tests: | ||
| name: jest-axe | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - name: Checkout Repository | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| ref: ${{ inputs.ref || github.ref }} | ||
|
|
||
| - name: Setup Node.js Environment | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: ${{ env.NODE_VERSION }} | ||
| cache: "npm" | ||
| cache-dependency-path: ./src/frontend/package-lock.json | ||
|
|
||
| # These are regression locks: every a11y unit test passes as of the | ||
| # component fixes in feat/a11y-unit-tests, so a failure here means a | ||
| # real a11y regression and blocks the PR. | ||
| - name: Run jest-axe unit tests | ||
| run: make test_frontend_a11y_unit_ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| ruleArchive: 19May2026 | ||
| policies: | ||
| - IBM_Accessibility | ||
| reportLevels: | ||
| - violation | ||
| # - potentialviolation | ||
| # - recommendation | ||
| # - potentialrecommendation | ||
| # - manual | ||
| outputFormat: | ||
| - html | ||
| - json | ||
| outputFilenameTimestamp: false | ||
| baselineFolder: tests/baselines | ||
| outputFolder: coverage/accessibility-reports |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.