-
Notifications
You must be signed in to change notification settings - Fork 9.8k
feat(bundles): metapackage split (Phase A) — engine-only lfx, lfx-bundles long tail, 5 graduated partner packages #13563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
1f46056
dbedb8f
8afc5ad
5bec743
8a4e311
1aa104a
883789c
7cd1673
51f8ecf
8788f9c
2b5faf2
7139d07
9df9475
5ec49d8
cbe8d23
98cd335
f550c6d
031ca0a
5fbac3d
e77ddc2
7266606
57ca736
dfc4f00
a082afb
11dacc4
dcbe03f
c10e409
5b8dd8a
9b00fee
fee3f38
b97579c
594e4db
f95fb06
fc07c98
ed39670
6bcae89
7f6d93b
3f7d2de
a05d937
61a55e8
064069b
de1efb9
87ae8a9
1590431
3340292
b169c86
00bf723
6109323
a5eac88
aecbb6b
ee912f6
6050924
e13fca1
f516062
1e2395a
d69b2a0
f7b9cb3
f629082
9ed867d
ce6ffc7
af7a5c3
41e18ce
bf38518
97381ae
7a6d989
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -86,6 +86,11 @@ | |
| "seed-directory-not-found", | ||
| "seed-bundle-shadowed", | ||
| "bundle-shadowed", | ||
| # Manifest-less lfx.bundles root whose entry-point declaration could | ||
| # not be resolved to a real package directory. Surfaced as a *warning* | ||
| # (never aborts startup) so a broken third-party declaration degrades | ||
| # to "that bundle root is skipped". | ||
| "bundle-discovery-malformed", | ||
| "duplicate-extension-id", | ||
| # Reload-specific codes | ||
| "reload-in-progress", | ||
|
|
@@ -284,6 +289,9 @@ def __bool__(self) -> bool: # pragma: no cover - convenience | |
| "Bundle {content!r} is registered from multiple discovery sources; the lower-precedence copy " | ||
| "at {location} is being skipped in favor of the higher-precedence one." | ||
| ), | ||
| "bundle-discovery-malformed": ( | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This template serves three failure modes in
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in 883789c — split per failure mode, mirroring the inline tier as you suggested: |
||
| "lfx.bundles entry point {content!r} could not be resolved to a package directory: {message}" | ||
| ), | ||
| "duplicate-extension-id": ("Extension id {content!r} is registered more than once (already at {location})."), | ||
| "reload-in-progress": ( | ||
| "Reload already in progress for bundle {content!r}; refuse to start a second concurrent reload." | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.