fix(a11y): label icon-only controls - #13678
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThe frontend adds accessible names and hidden-icon markers across app shell, sidebar, folder, node, chat, modal, and voice-assistant controls. It also adds fullscreen sidebar focus trapping and inert/aria-hidden handling for playground layouts, plus matching locale strings and accessibility tests. ChangesFrontend accessibility updates
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 7 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (7 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Test Coverage AdvisorNo source changes detected without accompanying tests. Thanks for keeping coverage up! 🎉
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-1.11.0 #13678 +/- ##
==================================================
+ Coverage 59.68% 59.77% +0.09%
==================================================
Files 2345 2347 +2
Lines 224397 224740 +343
Branches 31475 31624 +149
==================================================
+ Hits 133921 134328 +407
+ Misses 88942 88879 -63
+ Partials 1534 1533 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
* fix: improve auth accessibility coverage * fix(a11y): restore delete trigger tab focus * test(dialog): cover nested description
d3edf98 to
4ed4cec
Compare
Summary
SidebarTriggerchildren so custom trigger rendering is still named.Validation
uv run git commitpre-commit hooks: case conflicts, whitespace, secrets, Biome, staged no-any check.cd src/frontend && npx @biomejs/biome check <touched Playground/IO files>cd src/frontend && npm test -- --runInBand src/components/core/playgroundComponent/chat-view/chat-input/__tests__/chat-input.test.tsx src/components/core/playgroundComponent/chat-view/chat-header/components/__tests__/chat-sidebar.test.tsx src/components/core/playgroundComponent/chat-view/chat-header/components/__tests__/session-selector.test.tsxcd src/frontend && npm run a11y:report --silent -- --jsontextarea[data-testid="input-chat-playground"]; fullscreen Playground has dialog semantics;Tabwraps fromSendtoNew Chat;Shift+Tabwraps fromNew ChattoSend; hidden fullscreen controls are underinert.QA Regression Checklist
Playground; focus should move into the Playground chat input and not remain on the toolbar button.Shift+Tabfrom the first Playground control; focus should wrap to the last Playground control and not escape underneath.Enter fullscreenshould not be keyboard reachable or announced as active controls.Notes
aria-controlsfindings remain separate follow-up work.Refs LE-1516
Summary by CodeRabbit
New Features
Bug Fixes