fix: store deployment timestamps with microsecond precision on SQLite - #14010
Draft
HzaRashid wants to merge 2 commits into
Draft
fix: store deployment timestamps with microsecond precision on SQLite#14010HzaRashid wants to merge 2 commits into
HzaRashid wants to merge 2 commits into
Conversation
…Lite SQLite func.now() wrote whole-second strings that failed keyset equality against SQLAlchemy DateTime binds; rewrite existing rows and switch deployment-family models to Python utc_now defaults.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
✅ Migration Validation Passed All migrations follow the Expand-Contract pattern correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On SQLite,
func.now()/datetime('now')store second-level precision (YYYY-MM-DD HH:MM:SS). When that same value is loaded into Python and SQLAlchemy later sends it as a query parameter, it is formatted with microsecond precision (...SS.ffffff). Comparisons then fail when one side is the stored ORM column value (still second-level text) and the other is SQLAlchemy's DateTime formatting of a previously loaded ORM datetime used as a parameter — even if both represent the same wall-clock second.Rewriting once through
DateTime(timezone=True), plus changing the deployment-family models to write UTC via Columndefault/onupdate, makes what is stored match what SQLAlchemy sends later, so ordinary equality/ordering work without per-query workarounds.