feat(feature-parity) LF <> LFX Services Layer Tiering & Separation#14031
feat(feature-parity) LF <> LFX Services Layer Tiering & Separation#14031dkaushik94 wants to merge 4 commits into
Conversation
…nd VariableService to LFX service discovery routine to return service objects, and not None. Internal method calls still call noop, but avoids disgraceful errors such as AttributeError(s).
…service switch based on evnironment.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Test Coverage AdvisorNo source changes detected without accompanying tests. Thanks for keeping coverage up! 🎉
|
d1ceb1c to
69bad2f
Compare
|
✅ Migration Validation Passed All migrations follow the Expand-Contract pattern correctly. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor/orm-models-to-lfx #14031 +/- ##
==============================================================
- Coverage 59.17% 59.07% -0.11%
==============================================================
Files 2372 2325 -47
Lines 226897 225075 -1822
Branches 32310 31746 -564
==============================================================
- Hits 134267 132954 -1313
+ Misses 91021 90513 -508
+ Partials 1609 1608 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…efinitions to LFX from langflow-base.
| assert isinstance(service, MemoryService) | ||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_store_and_get_roundtrip(self) -> None: |
There was a problem hiding this comment.
Is there a specific reason we have tests in the src/ class?
TBD