-
Notifications
You must be signed in to change notification settings - Fork 9.8k
fix: expose stable Langfuse trace IO for evaluators #14089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
erichare
merged 3 commits into
release-1.11.0
from
fix/release-1.11.0-langfuse-trace-io-jsonpath
Jul 15, 2026
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Scalar/list collapse should be based on how many values were actually found, not how many components were marked.
values[0] if len(boundary_traces) == 1 else values(Line 81) uses the count of registered boundary trace names, not the count of values that actually survived the empty-dict skip at Line 74-75. If two components are marked on the same side (e.g. two output-marked components) but one of them produces{}for a given execution (common with conditional/router branches), only one value ends up invalues, yet the function still returns it wrapped in a single-element list instead of collapsing to a scalar — becauselen(boundary_traces) == 2. This breaks the "stable evaluator-addressable scalar" contract the PR is meant to guarantee, since the same flow can non-deterministically return a scalar or a one-item list foroutput/inputdepending on which branch executed.None of the added tests exercise this "mixed marked components, one contributes nothing" case, so it currently slips through.
🐛 Proposed fix
if not values: return False, None - return True, values[0] if len(boundary_traces) == 1 else values + return True, values[0] if len(values) == 1 else valuesConsider also adding a regression test in
test_langfuse_v3_compatibility.pycovering two marked output components where one yields{}.📝 Committable suggestion
🤖 Prompt for AI Agents