Skip to content

chore: remove unused delete-account flow (dead route, stub page, orphaned translations) - #14111

Open
olayinkaadelakun wants to merge 2 commits into
release-1.12.0from
LE-1752
Open

chore: remove unused delete-account flow (dead route, stub page, orphaned translations)#14111
olayinkaadelakun wants to merge 2 commits into
release-1.12.0from
LE-1752

Conversation

@olayinkaadelakun

@olayinkaadelakun olayinkaadelakun commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

Removes the /account/delete feature entirely — it was an orphaned, non-functional stub: no nav/menu entry linked to it anywhere in the app, the confirm button called an empty handler with no API/mutation wired up, the confirmation input was unbound, and there's no self-service delete-account backend endpoint to call in the first place. Rather than leave dead, misleading code in the router, it's being deleted outright.

THis convo helps
https://ibm-cloud.slack.com/archives/C093T95BN3G/p1784128038389479

Changes

  • routes.tsx — removed the DeleteAccountPage lazy import and the /account/delete route registration
  • pages/DeleteAccountPage/ — deleted the directory
  • All 7 locale files — removed the 5 now-orphaned deleteAccount.* translation keys

Test plan

  • Grepped src/ and tests/ for DeleteAccountPage, account/delete, and deleteAccount — no remaining references
  • npx biome check on routes.tsx and all locale files — clean
  • npx tsc --noEmit — no errors

Summary by CodeRabbit

  • New Features

    • Added Knowledge Base labels for linked flows, chunk counts, and character units.
    • Added localized labels for API key storage and node editing.
  • Bug Fixes

    • Removed the unavailable account deletion page and route.
    • Removed obsolete account deletion translations across supported languages.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 235f3713-b37c-4ee9-8da6-1178cac111f0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

The frontend removes the account deletion page route and its localized strings across supported locales. The English locale also adds Knowledge-base, API key, and node editor strings.

Changes

Account deletion removal

Layer / File(s) Summary
Remove account deletion route
src/frontend/src/routes.tsx, src/frontend/src/pages/DeleteAccountPage/index.tsx
The lazy DeleteAccountPage import and account/delete route were removed.
Remove account deletion translations
src/frontend/src/locales/*.json
The deleteAccount.* localization entries were removed from German, English, Spanish, French, Japanese, Portuguese, and Simplified Chinese locales.

Frontend locale additions

Layer / File(s) Summary
Add English interface strings
src/frontend/src/locales/en.json
English strings were added for linked flows, chunk labels, character counts, API key cards, and node editing.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: keval718

🚥 Pre-merge checks | ✅ 9
✅ Passed checks (9 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Test Coverage For New Implementations ✅ Passed Pure removal/cleanup PR: no new implementation was added, and no test files are included in the diff.
Test Quality And Coverage ✅ Passed Removal-only PR; no tests were added, and there are no frontend test files to assess for this deleted flow.
Test File Naming And Structure ✅ Passed No test files were added or modified; the PR only changes locales and routes, so this naming/structure check is not applicable.
Excessive Mock Usage Warning ✅ Passed No test files were added or modified in this PR, so there’s no mock-heavy test change to review.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically summarizes the main change: removing the unused delete-account flow and orphaned translations.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch LE-1752

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Test Coverage Advisor — tests appear to be missing

This PR changes source code but does not add or modify any test files.
This is an advisory check: it will not block this PR or any other job —
please add tests if the change is testable.

Frontend (TS/TSX) — no *.test.* / *.spec.* / tests/ change found

src/frontend/src/routes.tsx

Advisory check only — it always passes and is never a required status.

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 46%
46.82% (66856/142780) 70.12% (9386/13384) 45.3% (1538/3395)

Unit Test Results

Tests Skipped Failures Errors Time
5343 0 💤 0 ❌ 0 🔥 18m 17s ⏱️

@github-actions github-actions Bot added the lgtm This PR has been approved by a maintainer label Jul 20, 2026
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.94%. Comparing base (f8c5f9c) to head (cfa76f0).
⚠️ Report is 1 commits behind head on release-1.12.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-1.12.0   #14111      +/-   ##
==================================================
- Coverage           61.30%   60.94%   -0.36%     
==================================================
  Files                2342     2330      -12     
  Lines              237114   235094    -2020     
  Branches            33340    35215    +1875     
==================================================
- Hits               145354   143281    -2073     
- Misses              89963    90061      +98     
+ Partials             1797     1752      -45     
Flag Coverage Δ
frontend 59.33% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/frontend/src/routes.tsx 14.97% <ø> (-0.84%) ⬇️

... and 221 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@olayinkaadelakun
olayinkaadelakun changed the base branch from release-1.11.0 to release-1.12.0 July 22, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants