chore: remove unused delete-account flow (dead route, stub page, orphaned translations) - #14111
chore: remove unused delete-account flow (dead route, stub page, orphaned translations)#14111olayinkaadelakun wants to merge 2 commits into
Conversation
…aned translations)
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThe frontend removes the account deletion page route and its localized strings across supported locales. The English locale also adds Knowledge-base, API key, and node editor strings. ChangesAccount deletion removal
Frontend locale additions
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 9✅ Passed checks (9 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.12.0 #14111 +/- ##
==================================================
- Coverage 61.30% 60.94% -0.36%
==================================================
Files 2342 2330 -12
Lines 237114 235094 -2020
Branches 33340 35215 +1875
==================================================
- Hits 145354 143281 -2073
- Misses 89963 90061 +98
+ Partials 1797 1752 -45
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
Removes the
/account/deletefeature entirely — it was an orphaned, non-functional stub: no nav/menu entry linked to it anywhere in the app, the confirm button called an empty handler with no API/mutation wired up, the confirmation input was unbound, and there's no self-service delete-account backend endpoint to call in the first place. Rather than leave dead, misleading code in the router, it's being deleted outright.THis convo helps
https://ibm-cloud.slack.com/archives/C093T95BN3G/p1784128038389479
Changes
routes.tsx— removed theDeleteAccountPagelazy import and the/account/deleteroute registrationpages/DeleteAccountPage/— deleted the directorydeleteAccount.*translation keysTest plan
src/andtests/forDeleteAccountPage,account/delete, anddeleteAccount— no remaining referencesnpx biome checkonroutes.tsxand all locale files — cleannpx tsc --noEmit— no errorsSummary by CodeRabbit
New Features
Bug Fixes