Skip to content

fix(ci): keep core index check wheel-only#14139

Merged
erichare merged 1 commit into
release-1.11.0from
fix/release-core-index-metadata-ci
Jul 17, 2026
Merged

fix(ci): keep core index check wheel-only#14139
erichare merged 1 commit into
release-1.11.0from
fix/release-core-index-metadata-ci

Conversation

@erichare

@erichare erichare commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • keep the core-runtime verification independent of a source checkout
  • derive expected component-index metadata from the wheel-bundled entries
  • preserve the isolated indexed-import coverage

Fixes the failure in https://github.com/langflow-ai/langflow/actions/runs/29542552422/job/87773890440.

Validation

  • actionlint -shellcheck= .github/workflows/cross-platform-test.yml
  • embedded Python syntax compilation
  • current component-index metadata consistency (17 modules, 131 components)
  • pre-commit hooks

Summary by CodeRabbit

  • Tests
    • Updated cross-platform validation to verify component-index metadata against the generated index contents.
    • Removed reliance on a separate reference metadata file during validation.

@erichare
erichare merged commit a8ced37 into release-1.11.0 Jul 17, 2026
13 of 14 checks passed
@erichare
erichare deleted the fix/release-core-index-metadata-ci branch July 17, 2026 00:31
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0928f521-dce4-422b-a67f-3c2bf3c32491

📥 Commits

Reviewing files that changed from the base of the PR and between 902bb25 and 2fd7394.

📒 Files selected for processing (1)
  • .github/workflows/cross-platform-test.yml

Walkthrough

The cross-platform test workflow now derives expected component-index metadata from the in-memory index and compares it with the reported metadata, removing the repository golden-file dependency.

Changes

Component-index validation

Layer / File(s) Summary
Dynamic metadata assertion
.github/workflows/cross-platform-test.yml
The inline Python validation removes unused JSON and path imports, computes expected module and component counts from index entries, and compares them with index["metadata"].

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: vjgit96

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-core-index-metadata-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the bug Something isn't working label Jul 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Test Coverage Advisor

No source changes detected without accompanying tests. Thanks for keeping coverage up! 🎉

Advisory check only — never blocks merge.

@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant