fix: resolve UnboundLocalError by initializing assistant_message#1334
Open
ParasSondhi wants to merge 4 commits intolangflow-ai:mainfrom
Open
fix: resolve UnboundLocalError by initializing assistant_message#1334ParasSondhi wants to merge 4 commits intolangflow-ai:mainfrom
ParasSondhi wants to merge 4 commits intolangflow-ai:mainfrom
Conversation
Author
|
Hey team! 👋 Just a friendly ping on this bug fix. I just updated the branch so it's fully synced with main and has no conflicts. Let me know if there is anything else you need from my end to get those CI workflows approved and reviewed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the UnboundLocalError in async_langflow_chat_stream reported in #1333.
When a stream contains only tool-call activity, full_response remains empty, causing assistant_message to remain undefined before it is appended to conversation_state.
Changes
Initialized assistant_message = None before the full_response evaluation.
Added a conditional check if assistant_message is not None: before appending to conversation_state["messages"].
Resolves #1333