bug: Ingested documents are being shared will all users#1337
Open
ricofurtado wants to merge 3 commits intomainfrom
Open
bug: Ingested documents are being shared will all users#1337ricofurtado wants to merge 3 commits intomainfrom
ricofurtado wants to merge 3 commits intomainfrom
Conversation
github-actions
Bot
added
frontend
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| owner=user.user_id, | ||
| added_users=body.user_ids, | ||
| ) | ||
| return JSONResponse({"success": True, "allowed_users": merged, "acl_result": str(result)}) |
| owner=user.user_id, | ||
| removed_users=body.user_ids, | ||
| ) | ||
| return JSONResponse({"success": True, "allowed_users": remaining, "acl_result": str(result)}) |
Collaborator
|
@ricofurtado The initial issue in cloud was because the DLS was not applied in Saas Deployments. |
ricofurtado
changed the title
edwinjosechittilappilly
requested changes
Apr 8, 2026
Collaborator
edwinjosechittilappilly
left a comment
edwinjosechittilappilly
left a comment
There was a problem hiding this comment.
The DLS releated changes are in #1296
Lets merge this 1296 once tested and then revisit this functionality. cause this might chnage the ACL behaviour
|
|
||
| class ShareDocumentBody(BaseModel): | ||
| filename: str | ||
| user_ids: List[str] |
Collaborator
There was a problem hiding this comment.
It would be potentialy the owner name and email.
ACL to be be deduced or inherited from the Source for most connectors which priovide ACL.
Suggestion toRefer: dependecies.py for more context!
| ) | ||
|
|
||
| # Document ACL endpoints | ||
| app.add_api_route( |
Collaborator
There was a problem hiding this comment.
Good one!
Lets plan and implement it with respect to the product and Design team.
I like this idea of unshare.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files ingested by any user (including via IBM COS + IBM SSO) are currently visible to ALL authenticated users. The owner, allowed_users, and allowed_groups fields are stored in OpenSearch during ingestion but are never filtered