Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improved tracking and logging of worker slot contention in the
TaskService, making it easier to diagnose and monitor concurrency bottlenecks during file processing. The main changes include adding internal accounting for active and queued workers, logging when tasks wait for a worker slot, and updating tests to verify this behavior.Worker slot accounting and logging:
_worker_stats_lock,_active_workers, and_queued_workerstoTaskServicefor accurate tracking of worker slot usage. Introduced_acquire_processing_slotand_release_processing_slotasync methods to handle slot acquisition, release, and contention logging.Testing improvements:
test_logs_when_waiting_for_worker_slotto verify that contention is properly logged when tasks must wait for a worker slot.Minor cleanup: