Skip to content

fix(lark_trigger): fix serialization error for bitable record changed #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Night-stars-1 wants to merge 2 commits into from
Closed

fix(lark_trigger): fix serialization error for bitable record changed #2843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a39849
fix(lark_trigger): fix serialization error for bitable record changed
Night-stars-1 Apr 7, 2026
135f9a7
chore(lark_trigger): update version
Night-stars-1 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions triggers/lark_trigger/events/drive/file_bitable_record_changed_v1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,25 @@ def _on_event(self, request: Request, parameters: Mapping[str, Any], payload: Ma
actions = []
for action in event_data.action_list:
if action:
before_value = []
if action.before_value:
for before_value_item in action.before_value:
before_value.append({
"field_id": before_value_item.field_id if before_value_item.field_id else "",
"field_value": before_value_item.field_value if before_value_item.field_value else ""
})
after_value = []
if action.after_value:
for after_value_item in action.after_value:
after_value.append({
"field_id": after_value_item.field_id if after_value_item.field_id else "",
"field_value": after_value_item.field_value if after_value_item.field_id else ""
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There is a typo in the conditional check for field_value. It currently checks after_value_item.field_id instead of after_value_item.field_value. This makes the logic inconsistent with the before_value processing on line 54 and may result in None being assigned to field_value if the actual value is None but the field_id exists.

Suggested change
"field_value": after_value_item.field_value if after_value_item.field_id else ""
"field_value": after_value_item.field_value if after_value_item.field_value else ""

})
action_info = {
"action": action.action if action.action else "",
"record_id": action.record_id if action.record_id else "",
"before_value": action.before_value if action.before_value else "",
"after_value": action.after_value if action.after_value else "",
"before_value": before_value,
"after_value": after_value,
}
actions.append(action_info)
variables_dict["actions"] = actions
Expand Down
14 changes: 12 additions & 2 deletions triggers/lark_trigger/events/drive/file_bitable_record_changed_v1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,19 @@ output_schema:
record_id:
type: string
before_value:
type: string
type: object
properties:
field_id:
type: string
field_value:
type: string
after_value:
type: string
type: object
properties:
field_id:
type: string
field_value:
type: string
description: List of record actions performed

action_count:
Expand Down
2 changes: 1 addition & 1 deletion triggers/lark_trigger/manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ resource:
tags:
- utilities
type: plugin
version: 0.0.3
version: 0.0.4
Loading