Fix fracture regression tests and parallelize cohesive zone update#326
Open
alexholmes814 wants to merge 4 commits into
Open
Fix fracture regression tests and parallelize cohesive zone update#326alexholmes814 wants to merge 4 commits into
alexholmes814 wants to merge 4 commits into
Conversation
Collaborator
|
i think parallel operations should be wider in scope, comparing function names to the research code it's safe to do oriented through vczloads not just the update function i'd say rework the functions to not be member functions to avoid unnecessary memory movement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates fracture regression tests so the Mode I and Mode II fracture cases are driven using both velocity initial conditions and velocity boundary conditions. The combined IC + BC setup improves dynamic consistency and reduces startup transients. Fracture input file comments were corrected to be correct and consistent units. Fracture setup prints were cleaned up and the cohesive zone update received a performance boost.
Type of change
Please select all relevant options
How Has This Been Tested?
Test Configuration:
Checklist: