Skip to content

Fix fracture regression tests and parallelize cohesive zone update#326

Open
alexholmes814 wants to merge 4 commits into
lanl:mainfrom
alexholmes814:fracture-summer-2026
Open

Fix fracture regression tests and parallelize cohesive zone update#326
alexholmes814 wants to merge 4 commits into
lanl:mainfrom
alexholmes814:fracture-summer-2026

Conversation

@alexholmes814

@alexholmes814 alexholmes814 commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR updates fracture regression tests so the Mode I and Mode II fracture cases are driven using both velocity initial conditions and velocity boundary conditions. The combined IC + BC setup improves dynamic consistency and reduces startup transients. Fracture input file comments were corrected to be correct and consistent units. Fracture setup prints were cleaned up and the cohesive zone update received a performance boost.

Type of change

Please select all relevant options

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Formatting and/or style fixes
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

  • OS version: Microsoft Windows 11 Enterprise Version 10.0.22631 Build 22631 with WSL Ubuntu 22.04
  • Hardware: CPU: 13th Gen Intel(R) Core(TM) i7-13700H, 2400 Mhz, 14 Core(s), 20 Logical Processor(s)
  • Compiler: GCC 11.4.0 / G++ 11.4.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code builds from scratch with my new changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gavinwhetstone

Copy link
Copy Markdown
Collaborator

i think parallel operations should be wider in scope, comparing function names to the research code it's safe to do oriented through vczloads not just the update function

i'd say rework the functions to not be member functions to avoid unnecessary memory movement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants