Skip to content

LNK-4423: Fix ResourceType query - #1242

Merged
nvmLantana merged 3 commits into
devfrom
nvm/LNK-4423_FixQuery
Nov 6, 2025
Merged

LNK-4423: Fix ResourceType query#1242
nvmLantana merged 3 commits into
devfrom
nvm/LNK-4423_FixQuery

Conversation

@nvmLantana

@nvmLantana nvmLantana commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

🛠️ Description of Changes

Please provide a high-level overview of the changes included in this PR.

🧪 Testing Performed

Please describe the testing that was performed on the changes included in this PR.

🧑‍🔬 Unit Testing

  • I have written or updated unit tests to cover my changes

📓 Documentation Updated

Please update any relevant sections in the project documentation that were impacted by the changes in the PR.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected resource type filtering in data acquisition queries to properly match resource types during search operations.

@coderabbitai

coderabbitai Bot commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

A query filter in DataAcquisitionLogQueries was modified to compare string representations of ResourceType values instead of direct collection comparison. This change affects how resources are matched when filtering SearchAsync results.

Changes

Cohort / File(s) Summary
ResourceType Filter Comparison Update
DotNet/DataAcquisition.Domain/Application/Queries/DataAcquisitionLogQueries.cs
Modified ResourceType matching logic to compare string representations (r.ResourceType.ToString() == model.ResourceType) instead of direct collection comparison

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify string-based comparison correctly matches all intended resource types, particularly Location resource type mentioned in the linked regression test
  • Confirm the change resolves the missing Location resource type in Patient bundle filtering
  • Check for similar ResourceType comparison patterns elsewhere in the codebase that might require the same fix

Suggested reviewers

  • amphillipsLGC
  • smailliwcs

Poem

🐰 A filter fix, oh so refined,
String comparisons now aligned,
Location found, no more to hide,
Resources matched with rabbit pride! ✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only the template structure with no actual content filled in; all sections (Description of Changes, Testing Performed, Unit Testing, Documentation) lack substantive information. Complete the description by providing actual details about the ResourceType filter changes, testing performed to validate the fix, and whether documentation was updated.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Linked Issues check ❓ Inconclusive The code change modifies ResourceType comparison logic which appears targeted at fixing the resource type matching issue described in LNK-4423, but the empty PR description prevents full verification of scope and completeness. Fill in the PR description with details explaining how the ResourceType filter modification resolves the Location resource type validation failure and confirm testing validates the fix.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly references the linked issue LNK-4423 and indicates a ResourceType query fix, directly corresponding to the changeset's ResourceType filter modification.
Out of Scope Changes check ✅ Passed The single file change modifies only the ResourceType filter comparison logic, which appears directly scoped to the LNK-4423 issue without introducing unrelated modifications.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nvmLantana
nvmLantana requested a review from smailliwcs November 6, 2025 19:47
@nvmLantana
nvmLantana merged commit e72874a into dev Nov 6, 2025
16 checks passed
@nvmLantana
nvmLantana deleted the nvm/LNK-4423_FixQuery branch November 6, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants