Skip to content

LNK-4533: enhance smoke test validations phase two #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leolantana merged 14 commits into from
Jan 7, 2026
Merged

LNK-4533: enhance smoke test validations phase two #1318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
865155f
Adding manifest file validation
leolantana Dec 9, 2025
567e3ea
Adding patient validations and adding enhanced wait method
leolantana Dec 9, 2025
059188b
completing 6 patient validation
leolantana Dec 9, 2025
8120310
Clean up loose comments
leolantana Dec 9, 2025
4b45f1e
adding severity enums
leolantana Dec 12, 2025
1bf9d8e
enhancing logging
leolantana Dec 12, 2025
ca30dbb
added all patient validation
leolantana Dec 12, 2025
bb05f95
Fixed Console formatting
leolantana Dec 12, 2025
5308024
Cleaned up formatting in console
leolantana Dec 12, 2025
3a11f54
Final logging cleanup
leolantana Dec 12, 2025
0762251
final clean up
leolantana Dec 12, 2025
659600e
Changing Error Severity to ERROR from Warning.
leolantana Jan 2, 2026
dafcfd0
cleaning log output
leolantana Jan 5, 2026
1c28295
Updating final counts and logging.
leolantana Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 24 additions & 37 deletions Tests/BackendE2ETests/AdhocReportingSmokeTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public async Task ExecuteSmokeTest()
[Fact]
[Trait("Category", "AdHocSingleMeasureSmokeTest")]
public async Task SmokeTest_GenerateSingleMeasureAdHocReport()
{
{
TestConfig.AdhocReportingSmokeTestConfig.RemoveFacilityConfig = true;
AdHocReportApiRequests apiE2E = new AdHocReportApiRequests(output);
SubmissionZipReader submissionReportZip = new SubmissionZipReader(output);
Expand All @@ -106,46 +106,38 @@ public async Task SmokeTest_GenerateSingleMeasureAdHocReport()

Stopwatch stopwatch = new Stopwatch();
stopwatch.Start();
output.WriteLine($"Stopwatch start {DateTime.UtcNow.ToString()}");

await measureLoader.LoadAsync();
apiE2E.Create_SingleMeasureAdHocTestFacility();
apiE2E.Create_SingleMeasureCensusConfiguration_AdHoc();
apiE2E.Create_SingleMeasureQueryDispatchConfig_AdHoc();
apiE2E.Create_SingleMeasure_FHIRQueryConfigByFacility_AdHoc();
apiE2E.Create_SingleMeasure_MontlhyQueryPlanByFacility_AdHoc();
apiE2E.Create_SingleMeasure_DischargeQueryPlanByFacility_AdHoc();
apiE2E.Create_SingleMeasureFHIRQueryListByFacility_AdHoc();
apiE2E.GenerateSingleMeasureAdHocReport_ACH();
output.WriteLine($"Stopwatch start {DateTime.UtcNow}");

await measureLoader.LoadAsync();
apiE2E.Create_SingleMeasureAdHocTestFacility();
apiE2E.Create_SingleMeasureCensusConfiguration_AdHoc();
apiE2E.Create_SingleMeasureQueryDispatchConfig_AdHoc();
apiE2E.Create_SingleMeasure_FHIRQueryConfigByFacility_AdHoc();
apiE2E.Create_SingleMeasure_MontlhyQueryPlanByFacility_AdHoc();
apiE2E.Create_SingleMeasure_DischargeQueryPlanByFacility_AdHoc();
apiE2E.Create_SingleMeasureFHIRQueryListByFacility_AdHoc();
apiE2E.GenerateSingleMeasureAdHocReport_ACH();

await submissionReportZip.WaitForSingleMeasureZipContentsAsync();
var failures = new List<string>();
try
{
await submissionReportZip.DownloadAndExtractSingleMeasureZipAsync(true);
TestConfig.ValidationHelper.TryRunValidation(submissionReportZip.SingleMeasureAdHocValidateFilesAppear, failures);
TestConfig.ValidationHelper.TryRunValidation(submissionReportZip.SingleMeasureAdHocValidateFilesDoNotAppear, failures);
TestConfig.ValidationHelper.TryRunValidation(() => submissionReportZip.ValidateSpecificPatientFileContents(3, 2000), failures);
TestConfig.ValidationHelper.TryRunValidation(submissionReportZip.ValidateSingleMeasureAdHocAggregateACHMFile, failures);
await submissionReportZip.WaitForSingleMeasureZipContentsAsync();
await submissionReportZip.DownloadAndExtractSingleMeasureZipAsync(save: true);

submissionReportZip.SingleMeasureAdHocValidateFilesAppear();
submissionReportZip.SingleMeasureAdHocValidateFilesDoNotAppear();
submissionReportZip.ValidateSingleMeasureAdHocAggregateACHMFile();
submissionReportZip.ValidateAllPatientsWithConfigurableSeverity();

apiE2E.GETSingleMeasureAdHocFacilityValidationResultsForReport();

output.WriteLine("[PASS] Smoke test completed with all verifications passing.");
}
finally
{
if (failures.Any())
{
output.WriteLine("🔴 ================= TEST RESULT SUMMARY =================🔴 ");
foreach (var fail in failures)
output.WriteLine(fail);
Xunit.Assert.Fail($"{failures.Count} verification(s) failed. See console output below.");
}
else
output.WriteLine("[PASS] Smoke test completed with all verifications passing.");

stopwatch.Stop();
output.WriteLine($"Stopwatch stop {DateTime.UtcNow.ToString()} - Total Time: {stopwatch.Elapsed}");
}
output.WriteLine($"Stopwatch stop {DateTime.UtcNow} - Total Time: {stopwatch.Elapsed}");
}
}

private async Task GenerateReport(string? measureId)
{
if (measureId == null)
Expand Down Expand Up @@ -181,15 +173,11 @@ private async Task GenerateReport(string? measureId)

var downloadedResources = await this.DownloadReport(reportId);

// Confirm that there is a file called "manifest.ndjson"
Assert.True(downloadedResources.ContainsKey("manifest.ndjson"), $"Expected report to include manifest.ndjson but it was not");
// TODO: Validate that it is correct

// Confirm that there is a file called "patient-{patientId}.ndjson"
foreach (var patientId in TestConfig.AdhocReportingSmokeTestConfig.PatientIds)
{
Assert.True(downloadedResources.ContainsKey($"patient-{patientId}.ndjson"), $"Expected report to include patient-{patientId}.ndjson but it was not");
// TODO: Validate that it is correct
}

output.WriteLine("Done generating and validating report.");
Expand Down Expand Up @@ -296,7 +284,6 @@ private async Task CreateNormalizationConfig()
output.WriteLine("Creating normalization config...");
var request = new RestRequest("normalization/Operations", Method.Post);

// Construct the request body with dynamic facilityId
var body = new
{
ResourceTypes = new[] { "Location" },
Expand Down
Loading
Loading