LNK-4651: add hoc type for adhoc report generation

[arianamihailescu]

🛠️ Description of Changes

Hide the AdHoc type column if value is not populated

🧪 Testing Performed

Tested locally

🧑‍🔬 Unit Testing

• I have written or updated unit tests to cover my changes

📓 Documentation Updated

Please update any relevant sections in the project documentation that were impacted by the changes in the PR.

Summary by CodeRabbit

• Bug Fixes
  • Fixed report view to correctly hide the AdHoc Source section when no ad-hoc type data is present, preventing unnecessary UI elements from displaying.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The AdHoc Source block in the facility view report template is now conditionally rendered based on the presence of reportSummary?.adHocType, ensuring this section only appears when an adHoc type value exists rather than always being displayed.

Changes

Cohort / File(s)	Summary
AdHoc Source Conditional Rendering Web/Admin.UI/src/app/components/tenant/facility-view/view-report/view-report.component.html	Wrapped AdHoc Source row block with conditional *ngIf="reportSummary?.adHocType" to skip rendering when adHoc type is absent

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

• PR #1372: Modifies the same view-report template by renaming the AdHoc Source label and updating adHocType enum/assignment logic in conjunction with conditional rendering
• PR #1345: Introduces the adHocType property to reportSummary and populates it, providing the data source required by this template's conditional check

Suggested reviewers

• amphillipsLGC

Poem

🐰 A Source appears, but only when it's due,
AdHoc type checked—conditional and true!
Hide it away when data's not there,
Template flows cleaner, with logical care. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Linked Issues check	❓ Inconclusive	The PR implements conditional rendering of the AdHoc type column based on value population, partially addressing the linked issue's requirement to track AdHoc type, though the implementation appears incomplete for the full tracking objective.	Verify that all backend changes for tracking AdHoc type (distinguishing manual vs. automated lists) are included in this or related PRs, and confirm UI changes fully support the feature requirements.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly references the linked issue (LNK-4651) and accurately describes the main change: adding AdHoc type functionality for adhoc report generation.
Description check	✅ Passed	The PR description follows the template structure with all main sections completed, though unit testing was not performed and documentation updates were noted but not detailed.
Out of Scope Changes check	✅ Passed	The changes are narrowly scoped to conditional rendering of the AdHoc type column in the facility view report component, directly aligned with the PR objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

🧹 Recent nitpick comments

Web/Admin.UI/src/app/components/tenant/facility-view/view-report/view-report.component.html (1)

60-68: Implementation looks correct for the PR objective.

The conditional rendering properly hides the "AdHoc Source" section when adHocType is not populated.

Minor observation: This template mixes Angular 17+ control flow syntax (@if) with the older structural directive syntax (*ngIf used elsewhere in this file, e.g., lines 1, 25, 200). Consider adopting one style consistently across the template for maintainability—either migrate other *ngIf usages to @if, or use *ngIf here for uniformity with the rest of the file.

♻️ Alternative using structural directive for consistency

-      `@if` (reportSummary?.adHocType) {
-        <div>
-          <div class="data-label">
-            AdHoc Source
-            <span class="data-value">{{reportSummary?.adHocType}}</span>
-          </div>
-        </div>
-      }
+      <div *ngIf="reportSummary?.adHocType">
+        <div class="data-label">
+          AdHoc Source
+          <span class="data-value">{{reportSummary?.adHocType}}</span>
+        </div>
+      </div>

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3f8f9ea and 905decd.

📒 Files selected for processing (1)

• Web/Admin.UI/src/app/components/tenant/facility-view/view-report/view-report.component.html

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

**: Pull requests that have "TECH_DEBT" in the title should only contain changes related to typos, unused code, linter/IDE suggestions, swagger specification updates,
and logging improvements. These TECH_DEBT PRs must not affect core functionality. All PRs that are not considered technical debt must include information on what
testing was performed in the description of the PR. If it does not, ask the author to provide details on what testing was performed.
When reviewing code, suggest unit tests using XUnit in the following scenarios:

• If/Else or Switch/Case blocks are introduced or modified — ensure each branch has a corresponding unit test.
• Logic that depends on service or interface configuration — suggest tests to validate different implementations are correctly resolved.
• No network activity (HTTP calls, sockets, etc.) should appear in unit tests. Recommend using mocks (via Moq) for any external communication.
  Large unit tests should be avoided; keeping unit tests small and focused on targeted business logic (i.e. string sanitization)

**: Pull requests that have DOCS in the title should only contain changes related to documentation within the /docs folder or in .md files through-out the code-base. The description
of the PR should specify what documentation was updated. Documentation updates should use EventCatalog.dev structure, where service-specific functionality should be described
in the service's index.mdx (i.e. /services/XXX/index.mdx or /domains/XXX/services/YYY/index.mdx). Configurations that are shared by multiple services should be
reflected in the /docs/docs/config files.

Files:

• Web/Admin.UI/src/app/components/tenant/facility-view/view-report/view-report.component.html

🧠 Learnings (2)

📓 Common learnings

Learnt from: amphillipsLGC
Repo: lantanagroup/link-cloud PR: 737
File: DotNet/Admin.BFF/Presentation/Endpoints/Aggregation/Handlers/Report/GetReportSummaries.cs:23-23
Timestamp: 2025-03-20T22:11:00.226Z
Learning: The facilityId validation in GetReportSummaries.Handle method in DotNet/Admin.BFF/Presentation/Endpoints/Aggregation/Handlers/Report/GetReportSummaries.cs will be implemented in a future phase of work by amphillipsLGC.

📚 Learning: 2025-03-20T22:11:00.226Z

Learnt from: amphillipsLGC
Repo: lantanagroup/link-cloud PR: 737
File: DotNet/Admin.BFF/Presentation/Endpoints/Aggregation/Handlers/Report/GetReportSummaries.cs:23-23
Timestamp: 2025-03-20T22:11:00.226Z
Learning: The facilityId validation in GetReportSummaries.Handle method in DotNet/Admin.BFF/Presentation/Endpoints/Aggregation/Handlers/Report/GetReportSummaries.cs will be implemented in a future phase of work by amphillipsLGC.

Applied to files:

• Web/Admin.UI/src/app/components/tenant/facility-view/view-report/view-report.component.html

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: Smoke Test with Docker Compose
• GitHub Check: Unit Tests for DotNet
• GitHub Check: Integration Tests
• GitHub Check: Analyze (java-kotlin)
• GitHub Check: Analyze (csharp)

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR addresses LNK-4651 by conditionally rendering the AdHoc Source section in the report view only when ad-hoc type data is present, preventing unnecessary UI elements from displaying when the value is empty.

Changes:

• Added conditional rendering logic to hide the AdHoc Source section when reportSummary?.adHocType is not populated

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.