Skip to content

LNK-4652: Census Facility Name Non-Editable - #1381

Merged
arianamihailescu merged 3 commits into
devfrom
LNK-4652-Census-FacilityName-NonEditable
Jan 20, 2026
Merged

LNK-4652: Census Facility Name Non-Editable#1381
arianamihailescu merged 3 commits into
devfrom
LNK-4652-Census-FacilityName-NonEditable

Conversation

@arianamihailescu

@arianamihailescu arianamihailescu commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

🛠️ Description of Changes

Disabled the facility name on update/creation

🧪 Testing Performed

Tested locally

🧑‍🔬 Unit Testing

  • I have written or updated unit tests to cover my changes

📓 Documentation Updated

Please update any relevant sections in the project documentation that were impacted by the changes in the PR.

Summary by CodeRabbit

  • Chores

    • Updated API endpoint configuration for internal services.
  • Refactor

    • Improved form initialization and data handling for better stability.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

Configuration and form initialization improvements across audit service and census admin component. Updates the Tenant Service URL endpoint in launch settings and refactors form control initialization timing while adding safer property access patterns.

Changes

Cohort / File(s) Summary
Audit Service Configuration
DotNet/Audit/Properties/launchSettings.json
Updated TenantServiceURL from http://localhost:8074/api to http://localhost:8074 for the http-docker profile, removing the /api path suffix.
Census Form Component
Web/Admin.UI/src/app/components/census/census-config-form/census-config-form.component.ts
Moved form control initialization from ngOnInit to constructor. Added optional chaining (this.item?.enabled) in ngOnChanges for safer property access with fallback to true.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • nvmLantana
  • seanmcilvenna

Poem

🐰 A service endpoint hops with grace,
The config finds its rightful place—
Forms now init when first they're built,
With safer chains to calm our guilt!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the issue number and describes the main change: making the census facility name non-editable during editing.
Description check ✅ Passed The PR description covers the required template sections including description of changes, testing performed, and unit testing checkbox, following the repository's template structure.
Linked Issues check ✅ Passed The code changes align with LNK-4652 requirement: the tightened optional chaining logic in ngOnChanges and form control handling in the census-config-form component support making the facility name field non-editable.
Out of Scope Changes check ✅ Passed All changes are scoped to the census configuration form component and related service endpoint settings, directly supporting the LNK-4652 objective of disabling the facility name field.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@arianamihailescu
arianamihailescu merged commit 26cdd03 into dev Jan 20, 2026
17 checks passed
@arianamihailescu
arianamihailescu deleted the LNK-4652-Census-FacilityName-NonEditable branch January 20, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants