LNK-5160: Improve Our Test Suite Efficiency - #1588
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR migrates integration tests to unit tests using mocks, removes test suites from DataAcquisition controllers and managers, adds equivalent unit test coverage, updates the integration test fixture to support external SQL Server connections, and updates the CI workflow to pull SQL Server Docker images. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~35 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
amphillipsLGC
approved these changes
Apr 22, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (8)
DotNet/ServiceTests/UnitTests/DataAcquisition/Managers/FhirQueryConfigurationManagerTests.cs (1)
125-135: Consider adding a symmetricUpdateAsync_MissingFacilityId_ThrowsArgumentNulltest.
CreateAsynchas coverage for both missingFacilityIdand missingFhirServerBaseUrl, butUpdateAsynconly covers the missing URL case. SinceUpdateAsyncvalidatesFacilityIdfirst (per the manager implementation), a parallel test would close the coverage gap and keep the suite symmetric.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@DotNet/ServiceTests/UnitTests/DataAcquisition/Managers/FhirQueryConfigurationManagerTests.cs` around lines 125 - 135, Add a symmetric unit test named UpdateAsync_MissingFacilityId_ThrowsArgumentNull that constructs the same test pattern as UpdateAsync_MissingFhirServerBaseUrl_ThrowsArgumentNull: use CreateManager() to get the manager, create an UpdateFhirQueryConfigurationModel with FhirServerBaseUrl set (but omit FacilityId), then assert that calling manager.UpdateAsync(model) throws an ArgumentNullException; this mirrors the existing CreateAsync coverage and verifies UpdateAsync validates FacilityId first.DotNet/ServiceTests/UnitTests/DataAcquisition/Controllers/QueryListControllerTests.cs (1)
204-217: Unused mock setup.
DeleteFhirConfigurationdoes not callIFhirQueryListConfigurationQueries.GetByFacilityIdAsync(see context snippet 4); it only invokes_fhirQueryListConfigurationManager.DeleteAsync. The setup on Lines 205-207 has no effect and can be removed to keep the test focused on what the endpoint actually exercises.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@DotNet/ServiceTests/UnitTests/DataAcquisition/Controllers/QueryListControllerTests.cs` around lines 204 - 217, Remove the unused mock setup for IFhirQueryListConfigurationQueries.GetByFacilityIdAsync in the test for DeleteFhirConfiguration; the controller only calls IFhirListQueryConfigurationManager.DeleteAsync, so keep the mock setup for IFhirListQueryConfigurationManager.DeleteAsync and remove the GetByFacilityIdAsync setup (referencing the test method that constructs the controller via CreateController and calls DeleteFhirConfiguration).DotNet/ServiceTests/UnitTests/DataAcquisition/Managers/DataAcquisitionLogManagerTests.cs (1)
21-39: Minor:DataAcquisitionDbContextis never disposed.The class holds an
_dbContextfield but doesn't implementIDisposable/IAsyncDisposable. xUnit creates a new test class instance per[Fact], so across the suite the InMemory provider accumulatesDataAcquisitionDbContextinstances (and their underlying InMemory store entries) until the test process exits. Not a correctness bug, but implementingIDisposableand disposing_dbContextkeeps the runner footprint small and matches the usual pattern.♻️ Optional refactor
-public class DataAcquisitionLogManagerTests +public class DataAcquisitionLogManagerTests : IDisposable { ... + public void Dispose() => _dbContext.Dispose(); }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@DotNet/ServiceTests/UnitTests/DataAcquisition/Managers/DataAcquisitionLogManagerTests.cs` around lines 21 - 39, Add disposal for the DataAcquisitionDbContext to avoid leaking InMemory contexts: have the DataAcquisitionLogManagerTests class implement IDisposable (or IAsyncDisposable) and in Dispose/DisposeAsync call _dbContext.Dispose() (or await _dbContext.DisposeAsync()), ensure you reference the existing _dbContext field and implement the interface on the DataAcquisitionLogManagerTests class so each test instance cleans up its DbContext after use.DotNet/ServiceTests/ServiceTests.csproj (1)
136-138: Empty<Folder Include>for a now-empty directory.Per the PR summary, all controller integration tests under
IntegrationTests\DataAcquisition\Controllers\have been deleted. This<Folder Include>entry (commonly auto-added by Visual Studio to preserve an empty folder in the project) only serves to keep that empty directory visible in Solution Explorer. If the folder isn't going to be repopulated shortly, consider deleting the directory and removing this ItemGroup rather than carrying an empty placeholder.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@DotNet/ServiceTests/ServiceTests.csproj` around lines 136 - 138, The project contains an unnecessary Folder Include for "IntegrationTests\DataAcquisition\Controllers\" in ServiceTests.csproj that was left after deleting all controller integration tests; remove the <ItemGroup> entry containing the Folder Include ("IntegrationTests\DataAcquisition\Controllers\") from ServiceTests.csproj and delete the now-empty directory from the repository (or ensure no other references remain) so the project file no longer preserves an unused placeholder folder.DotNet/ServiceTests/IntegrationTests/DataAcquisition/DataAcquisitionIntegrationTestFixture.cs (1)
220-233: Consider logging swallowed cleanup failures.The bare
catchsilently discards all exceptions, including unexpected ones (e.g.,OperationCanceledException, auth/connection errors against the external server). For test-infra diagnostics it's helpful to at least surface the failure to the console or test output so leaking databases on a shared external server are noticed.♻️ Suggested refinement
- catch - { - // Ignore cleanup failures - the next run uses a new GUID. - } + catch (Exception ex) + { + // Best-effort cleanup; surface the failure but don't fail disposal. + Console.Error.WriteLine( + $"[DataAcquisitionIntegrationTestFixture] Failed to drop test database '{_testDatabaseName}': {ex.Message}"); + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@DotNet/ServiceTests/IntegrationTests/DataAcquisition/DataAcquisitionIntegrationTestFixture.cs` around lines 220 - 233, The current bare catch in DataAcquisitionIntegrationTestFixture silently swallows all exceptions during DB cleanup; change the catch to catch (Exception ex) and write the exception details to test output (e.g., TestContext.WriteLine or Console.Error.WriteLine) so failures (auth/connection, cancellation, etc.) are visible for diagnostics; keep the behavior of not rethrowing but ensure the log includes ex.Message and ex.ToString() and reference the try block where masterConn/SqlConnection and cmd.ExecuteNonQueryAsync are used to locate the change.DotNet/ServiceTests/IntegrationTests/DataAcquisition/Managers/DataAcquisitionLogManagerTests.cs (1)
815-855:GetPendingRequests_ReturnsPendingLogsleaks cross-test coupling.This test seeds with a hardcoded
FacilityId = "TestFacility"and then callsSearchAsyncwith noFacilityIdfilter, so the result set will includePending/Failedlogs seeded by every other test in the collection (they all persist in the same shared DB now thatEnsureDeleted/EnsureCreatedis gone). The assertions still pass because they only check "any record" and "all records have an expected status", but the test is no longer verifying the seeded rows in particular. Consider filtering by a uniqueFacilityId(GUID-tagged, like the other tests) and asserting on the exact pending row.♻️ Suggested fix
- var pendingLog = new DataAcquisitionLog - { - FacilityId = "TestFacility", + var facilityId = $"TestFacility_{Guid.NewGuid():N}"; + var pendingLog = new DataAcquisitionLog + { + FacilityId = facilityId, Status = RequestStatus.Pending, ExecutionDate = DateTime.UtcNow.AddDays(-1), Priority = AcquisitionPriority.Normal }; var completedLog = new DataAcquisitionLog { - FacilityId = "TestFacility", + FacilityId = facilityId, Status = RequestStatus.Completed, ExecutionDate = DateTime.UtcNow.AddDays(-1) }; dbContext.DataAcquisitionLogs.AddRange(pendingLog, completedLog); await dbContext.SaveChangesAsync(); @@ var result = await queries.SearchAsync(new SearchDataAcquisitionLogRequest { + FacilityId = facilityId, RequestStatuses = [RequestStatus.Pending, RequestStatus.Failed] });🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@DotNet/ServiceTests/IntegrationTests/DataAcquisition/Managers/DataAcquisitionLogManagerTests.cs` around lines 815 - 855, The test GetPendingRequests_ReturnsPendingLogs is leaking cross-test data because it seeds entries with a hardcoded FacilityId and calls queries.SearchAsync without filtering; change the seeded pendingLog and completedLog FacilityId to a unique value (e.g., Guid.NewGuid().ToString()), pass that same FacilityId into the SearchAsync request (SearchDataAcquisitionLogRequest.FacilityId = uniqueId) and then assert against the exact expected row(s) (e.g., expect a single record with Status == RequestStatus.Pending and matching Id/FacilityId) instead of just Any() so the test verifies only the rows it created.DotNet/ServiceTests/UnitTests/DataAcquisition/Controllers/QueryConfigControllerTests.cs (1)
216-252: Assert the intended update branch is actually exercised.These tests configure
IFhirQueryConfigurationManager.UpdateAsync(...)to throw, but they only assert the final status code. AddVerify(...)calls, or remove unused setups for validation-only cases, so the tests cannot pass through a different BadRequest/NotFound short-circuit.♻️ Example tightening for the manager-exception path
var objectResult = (ObjectResult)result; Assert.Equal((int)HttpStatusCode.NotFound, objectResult.StatusCode); +_mocker.GetMock<IFhirQueryConfigurationManager>() + .Verify(x => x.UpdateAsync(It.IsAny<UpdateFhirQueryConfigurationModel>(), CancellationToken.None), Times.Once);For
UpdateFhirConfigurationNegativeTest_InvalidFacilityId, either verifyUpdateAsyncis never called if this is meant to test request validation, or pass a request that reaches the manager if this is meant to testArgumentNullExceptionhandling.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@DotNet/ServiceTests/UnitTests/DataAcquisition/Controllers/QueryConfigControllerTests.cs` around lines 216 - 252, The tests UpdateFhirConfigurationNegativeTest_NotFound and UpdateFhirConfigurationNegativeTest_InvalidFacilityId set up IFhirQueryConfigurationManager.UpdateAsync to throw but never assert that the controller actually invoked (or did not invoke) that manager path; update these tests to either call Verify on the IFhirQueryConfigurationManager mock (e.g., Verify(x => x.UpdateAsync(It.IsAny<UpdateFhirQueryConfigurationModel>(), CancellationToken.None), Times.Once()) for the exception-path tests) or, if the test is intended to exercise model validation short-circuiting, change the setup to Verify that UpdateAsync was never called (Times.Never()) and/or provide an input that will reach the manager when testing ArgumentNullException handling; reference the QueryConfigController.UpdateFhirConfiguration call and IFhirQueryConfigurationManager.UpdateAsync when making the Verify assertions so the test fails if the wrong branch is taken.DotNet/ServiceTests/UnitTests/DataAcquisition/Controllers/QueryPlanConfigControllerTests.cs (1)
313-421: Verify manager exception paths to avoid false-positive 500/400 assertions.Several tests configure manager exceptions but only assert the final status code. Add
Verify(...)calls forAddAsync/UpdateAsync, and set up any required precondition queries, so these tests prove the intended exception branch is reached.♻️ Example tightening for the update exception tests
_mocker.GetMock<IQueryPlanQueries>() .Setup(x => x.ExistsAsync(It.IsAny<string>(), It.IsAny<Frequency>(), CancellationToken.None)) .ReturnsAsync(true); +_mocker.GetMock<IQueryPlanQueries>() + .Setup(x => x.GetAsync(It.IsAny<string>(), It.IsAny<Frequency>(), CancellationToken.None)) + .ReturnsAsync(new QueryPlanModel()); _mocker.GetMock<IQueryPlanManager>() .Setup(x => x.UpdateAsync(It.IsAny<UpdateQueryPlanModel>(), CancellationToken.None)) .ThrowsAsync(new Exception("boom")); ... Assert.Equal((int)HttpStatusCode.InternalServerError, objectResult.StatusCode); +_mocker.GetMock<IQueryPlanManager>() + .Verify(x => x.UpdateAsync(It.IsAny<UpdateQueryPlanModel>(), CancellationToken.None), Times.Once);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@DotNet/ServiceTests/UnitTests/DataAcquisition/Controllers/QueryPlanConfigControllerTests.cs` around lines 313 - 421, Tests that assert on controller status codes for manager-thrown exceptions are missing verifications that the manager methods were actually invoked and the query preconditions were set up; update the tests (e.g., CreateQueryPlan_Exception_ReturnsInternalServerError and UpdateQueryPlan_InvalidQueryOrder_ReturnsBadRequest / UpdateQueryPlan_GenericException_ReturnsInternalServerError) to also Setup the required IQueryPlanQueries.ExistsAsync responses consistently and call _mocker.GetMock<IQueryPlanManager>().Verify(x => x.AddAsync(It.IsAny<CreateQueryPlanModel>(), CancellationToken.None)) or Verify(x => x.UpdateAsync(It.IsAny<UpdateQueryPlanModel>(), CancellationToken.None)) as appropriate to ensure the AddAsync/UpdateAsync exception path was exercised and not skipped. Ensure the mock setups for ExistsAsync use matching argument matchers (It.IsAny<string>(), It.IsAny<Frequency>()) so the controller reaches the manager call before verifying.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@DotNet/ServiceTests/UnitTests/DataAcquisition/Controllers/LogControllerTests.cs`:
- Around line 419-432: The test for ProcessByFilter currently returns an empty
PagedConfigModel so it never exercises the branch that triggers the retrieval
workflow; update the mock setup for IDataAcquisitionLogQueries.SearchAsync to
return a PagedConfigModel containing at least one
DataAcquisitionLogSummaryModel, call controller.ProcessByFilter with the same
LogSearchParameters, and then verify that the injected
IDataAcquisitionRetrievalService (or equivalent) StartRetrievalProcessBulk
method was invoked (use the same AutoMocker/CreateController to resolve and
assert the mock call). Ensure you reference ProcessByFilter,
IDataAcquisitionLogQueries.SearchAsync, StartRetrievalProcessBulk,
CreateController and LogSearchParameters when making the change.
In
`@DotNet/ServiceTests/UnitTests/DataAcquisition/Controllers/QueryListControllerTests.cs`:
- Around line 230-243: The test asserts NotFound but DeleteFhirConfiguration
never returns NotFound; update the test to mock the manager's delete behavior to
match controller semantics: in the test use
mocker.GetMock<IFhirQueryListConfigurationManager>().Setup(m =>
m.DeleteAsync(It.IsAny<string>(),
It.IsAny<CancellationToken>())).ThrowsAsync(new
MissingFacilityConfigurationException(...)) and then assert the
controller.DeleteFhirConfiguration(...) returns a BadRequestObjectResult, or
alternatively mock DeleteAsync to return false and assert OkObjectResult(false);
adjust the assertion and the mock setup in the
DeleteFhirConfiguration_NonExisting_ReturnsNotFound test accordingly (use
CreateController to build the controller and reference DeleteFhirConfiguration,
IFhirQueryListConfigurationManager.DeleteAsync, and
MissingFacilityConfigurationException).
---
Nitpick comments:
In
`@DotNet/ServiceTests/IntegrationTests/DataAcquisition/DataAcquisitionIntegrationTestFixture.cs`:
- Around line 220-233: The current bare catch in
DataAcquisitionIntegrationTestFixture silently swallows all exceptions during DB
cleanup; change the catch to catch (Exception ex) and write the exception
details to test output (e.g., TestContext.WriteLine or Console.Error.WriteLine)
so failures (auth/connection, cancellation, etc.) are visible for diagnostics;
keep the behavior of not rethrowing but ensure the log includes ex.Message and
ex.ToString() and reference the try block where masterConn/SqlConnection and
cmd.ExecuteNonQueryAsync are used to locate the change.
In
`@DotNet/ServiceTests/IntegrationTests/DataAcquisition/Managers/DataAcquisitionLogManagerTests.cs`:
- Around line 815-855: The test GetPendingRequests_ReturnsPendingLogs is leaking
cross-test data because it seeds entries with a hardcoded FacilityId and calls
queries.SearchAsync without filtering; change the seeded pendingLog and
completedLog FacilityId to a unique value (e.g., Guid.NewGuid().ToString()),
pass that same FacilityId into the SearchAsync request
(SearchDataAcquisitionLogRequest.FacilityId = uniqueId) and then assert against
the exact expected row(s) (e.g., expect a single record with Status ==
RequestStatus.Pending and matching Id/FacilityId) instead of just Any() so the
test verifies only the rows it created.
In `@DotNet/ServiceTests/ServiceTests.csproj`:
- Around line 136-138: The project contains an unnecessary Folder Include for
"IntegrationTests\DataAcquisition\Controllers\" in ServiceTests.csproj that was
left after deleting all controller integration tests; remove the <ItemGroup>
entry containing the Folder Include
("IntegrationTests\DataAcquisition\Controllers\") from ServiceTests.csproj and
delete the now-empty directory from the repository (or ensure no other
references remain) so the project file no longer preserves an unused placeholder
folder.
In
`@DotNet/ServiceTests/UnitTests/DataAcquisition/Controllers/QueryConfigControllerTests.cs`:
- Around line 216-252: The tests UpdateFhirConfigurationNegativeTest_NotFound
and UpdateFhirConfigurationNegativeTest_InvalidFacilityId set up
IFhirQueryConfigurationManager.UpdateAsync to throw but never assert that the
controller actually invoked (or did not invoke) that manager path; update these
tests to either call Verify on the IFhirQueryConfigurationManager mock (e.g.,
Verify(x => x.UpdateAsync(It.IsAny<UpdateFhirQueryConfigurationModel>(),
CancellationToken.None), Times.Once()) for the exception-path tests) or, if the
test is intended to exercise model validation short-circuiting, change the setup
to Verify that UpdateAsync was never called (Times.Never()) and/or provide an
input that will reach the manager when testing ArgumentNullException handling;
reference the QueryConfigController.UpdateFhirConfiguration call and
IFhirQueryConfigurationManager.UpdateAsync when making the Verify assertions so
the test fails if the wrong branch is taken.
In
`@DotNet/ServiceTests/UnitTests/DataAcquisition/Controllers/QueryListControllerTests.cs`:
- Around line 204-217: Remove the unused mock setup for
IFhirQueryListConfigurationQueries.GetByFacilityIdAsync in the test for
DeleteFhirConfiguration; the controller only calls
IFhirListQueryConfigurationManager.DeleteAsync, so keep the mock setup for
IFhirListQueryConfigurationManager.DeleteAsync and remove the
GetByFacilityIdAsync setup (referencing the test method that constructs the
controller via CreateController and calls DeleteFhirConfiguration).
In
`@DotNet/ServiceTests/UnitTests/DataAcquisition/Controllers/QueryPlanConfigControllerTests.cs`:
- Around line 313-421: Tests that assert on controller status codes for
manager-thrown exceptions are missing verifications that the manager methods
were actually invoked and the query preconditions were set up; update the tests
(e.g., CreateQueryPlan_Exception_ReturnsInternalServerError and
UpdateQueryPlan_InvalidQueryOrder_ReturnsBadRequest /
UpdateQueryPlan_GenericException_ReturnsInternalServerError) to also Setup the
required IQueryPlanQueries.ExistsAsync responses consistently and call
_mocker.GetMock<IQueryPlanManager>().Verify(x =>
x.AddAsync(It.IsAny<CreateQueryPlanModel>(), CancellationToken.None)) or
Verify(x => x.UpdateAsync(It.IsAny<UpdateQueryPlanModel>(),
CancellationToken.None)) as appropriate to ensure the AddAsync/UpdateAsync
exception path was exercised and not skipped. Ensure the mock setups for
ExistsAsync use matching argument matchers (It.IsAny<string>(),
It.IsAny<Frequency>()) so the controller reaches the manager call before
verifying.
In
`@DotNet/ServiceTests/UnitTests/DataAcquisition/Managers/DataAcquisitionLogManagerTests.cs`:
- Around line 21-39: Add disposal for the DataAcquisitionDbContext to avoid
leaking InMemory contexts: have the DataAcquisitionLogManagerTests class
implement IDisposable (or IAsyncDisposable) and in Dispose/DisposeAsync call
_dbContext.Dispose() (or await _dbContext.DisposeAsync()), ensure you reference
the existing _dbContext field and implement the interface on the
DataAcquisitionLogManagerTests class so each test instance cleans up its
DbContext after use.
In
`@DotNet/ServiceTests/UnitTests/DataAcquisition/Managers/FhirQueryConfigurationManagerTests.cs`:
- Around line 125-135: Add a symmetric unit test named
UpdateAsync_MissingFacilityId_ThrowsArgumentNull that constructs the same test
pattern as UpdateAsync_MissingFhirServerBaseUrl_ThrowsArgumentNull: use
CreateManager() to get the manager, create an UpdateFhirQueryConfigurationModel
with FhirServerBaseUrl set (but omit FacilityId), then assert that calling
manager.UpdateAsync(model) throws an ArgumentNullException; this mirrors the
existing CreateAsync coverage and verifies UpdateAsync validates FacilityId
first.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6c69dbdd-71d3-4f61-b311-aaaf9c5eda80
📒 Files selected for processing (17)
.github/workflows/tests.yamlDotNet/ServiceTests/IntegrationTests/DataAcquisition/Controllers/LogControllerTests.csDotNet/ServiceTests/IntegrationTests/DataAcquisition/Controllers/QueryConfigControllerTests.csDotNet/ServiceTests/IntegrationTests/DataAcquisition/Controllers/QueryListControllerTests.csDotNet/ServiceTests/IntegrationTests/DataAcquisition/Controllers/QueryPlanConfigControllerTests.csDotNet/ServiceTests/IntegrationTests/DataAcquisition/DataAcquisitionIntegrationTestFixture.csDotNet/ServiceTests/IntegrationTests/DataAcquisition/Managers/DataAcquisitionLogManagerTests.csDotNet/ServiceTests/IntegrationTests/DataAcquisition/Managers/FhirListQueryConfigurationManagerTests.csDotNet/ServiceTests/IntegrationTests/DataAcquisition/Managers/FhirQueryConfigurationManagerTests.csDotNet/ServiceTests/ServiceTests.csprojDotNet/ServiceTests/UnitTests/DataAcquisition/Controllers/LogControllerTests.csDotNet/ServiceTests/UnitTests/DataAcquisition/Controllers/QueryConfigControllerTests.csDotNet/ServiceTests/UnitTests/DataAcquisition/Controllers/QueryListControllerTests.csDotNet/ServiceTests/UnitTests/DataAcquisition/Controllers/QueryPlanConfigControllerTests.csDotNet/ServiceTests/UnitTests/DataAcquisition/Managers/DataAcquisitionLogManagerTests.csDotNet/ServiceTests/UnitTests/DataAcquisition/Managers/FhirListQueryConfigurationManagerTests.csDotNet/ServiceTests/UnitTests/DataAcquisition/Managers/FhirQueryConfigurationManagerTests.cs
💤 Files with no reviewable changes (6)
- DotNet/ServiceTests/IntegrationTests/DataAcquisition/Managers/FhirListQueryConfigurationManagerTests.cs
- DotNet/ServiceTests/IntegrationTests/DataAcquisition/Managers/FhirQueryConfigurationManagerTests.cs
- DotNet/ServiceTests/IntegrationTests/DataAcquisition/Controllers/QueryPlanConfigControllerTests.cs
- DotNet/ServiceTests/IntegrationTests/DataAcquisition/Controllers/QueryListControllerTests.cs
- DotNet/ServiceTests/IntegrationTests/DataAcquisition/Controllers/QueryConfigControllerTests.cs
- DotNet/ServiceTests/IntegrationTests/DataAcquisition/Controllers/LogControllerTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Description of Changes
Improve Our Test Suite Efficiency
🧪 Testing Performed
Please describe the testing that was performed on the changes included in this PR.
🧑🔬 Unit Testing
📓 Documentation Updated
Please update any relevant sections in the project documentation that were impacted by the changes in the PR.
Summary by CodeRabbit