Skip to content

LEGLINK-743: Move Vendor Model Out of Normalization and Into Tenant - #1782

Merged
johnbritton merged 12 commits into
devfrom
users/jbritton/LEGLINK-743
Aug 4, 2026
Merged

LEGLINK-743: Move Vendor Model Out of Normalization and Into Tenant#1782
johnbritton merged 12 commits into
devfrom
users/jbritton/LEGLINK-743

Conversation

@johnbritton

@johnbritton johnbritton commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🛠️ Description of Changes

  1. Moved Vendor and VendorVersion from the Normalization service to the Tenant service.
  2. Removed the obsolete Vendor enums.
  3. Facilities and normalization operations reference VendorVersions instead of vendor strings/enums.
  4. Update LinkSDK

🧪 Testing Performed

Unit tests, UI tests, automation tests, API health checks.

🧑‍🔬 Unit Testing

  • I have written or updated unit tests to cover my changes
  • Coverage: 10.7%

📓 Documentation Updated

Keystone will need updated after this PR.

@johnbritton
johnbritton requested review from a team as code owners August 4, 2026 18:34
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Too many files!

This PR contains 131 files, which is 31 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6a92971d-62ab-4c43-ba63-20fe74e1100b

📥 Commits

Reviewing files that changed from the base of the PR and between 73d5b0c and 68ae3bb.

📒 Files selected for processing (131)
  • DotNet/Admin.BFF/appsettings.json
  • DotNet/Automation.Link/Helpers/FacilitySetupHelper.cs
  • DotNet/Automation.UI/Services/ApiHealth/TestSuites/AdminBffTestSuite.cs
  • DotNet/Automation.UI/Services/ApiHealth/TestSuites/ApiEndPointLibrary.cs
  • DotNet/Automation.UI/Services/ApiHealth/TestSuites/CensusServiceTestSuite.cs
  • DotNet/Automation.UI/Services/ApiHealth/TestSuites/DataAcquisitionTestSuite.cs
  • DotNet/Automation.UI/Services/ApiHealth/TestSuites/NormalizationTestSuite.cs
  • DotNet/Automation.UI/Services/ApiHealth/TestSuites/QueryDispatchTestSuite.cs
  • DotNet/Automation.UI/Services/ApiHealth/TestSuites/TenantServiceTestSuite.cs
  • DotNet/Automation.UI/Services/RunExecutor.cs
  • DotNet/DataAcquisition/Controllers/EncounterMappingController.cs
  • DotNet/DataAcquisition/Controllers/LogController.cs
  • DotNet/LinkSdk/Clients/FacilityServiceClient.cs
  • DotNet/LinkSdk/Clients/Interfaces/IFacilityServiceClient.cs
  • DotNet/LinkSdk/Clients/Interfaces/INormalizationServiceClient.cs
  • DotNet/LinkSdk/Clients/NormalizationServiceClient.cs
  • DotNet/LinkSdk/README.md
  • DotNet/Normalization/Application/Models/Operations/Business/Manager/CreateOperationModel.cs
  • DotNet/Normalization/Application/Models/Operations/Business/Manager/CreateVendorVersionModel.cs
  • DotNet/Normalization/Application/Models/Operations/Business/Manager/DeleteOperationModel.cs
  • DotNet/Normalization/Application/Models/Operations/Business/Manager/UpdateOperationModel.cs
  • DotNet/Normalization/Application/Models/Operations/Business/Query/OperationSearchModel.cs
  • DotNet/Normalization/Application/Models/Operations/Business/Query/VendorOperationPresetSearchModel.cs
  • DotNet/Normalization/Application/Models/Operations/Business/Query/VendorSearchModel.cs
  • DotNet/Normalization/Application/Models/Operations/Business/Query/VendorVersionOperationPresetSearchModel.cs
  • DotNet/Normalization/Application/Models/Operations/Business/VendorModel.cs
  • DotNet/Normalization/Application/Models/Operations/Business/VendorVersionModel.cs
  • DotNet/Normalization/Application/Models/Operations/Business/VendorVersionOperationPresetModel.cs
  • DotNet/Normalization/Application/Models/Operations/HttpModels/PostOperationModel.cs
  • DotNet/Normalization/Application/Models/Operations/HttpModels/PutOperationModel.cs
  • DotNet/Normalization/Application/Models/Operations/HttpModels/VendorVersionOperationPresetPostModel.cs
  • DotNet/Normalization/Controllers/OperationsController.cs
  • DotNet/Normalization/Controllers/VendorController.cs
  • DotNet/Normalization/Controllers/VendorVersionOperationPresetsController.cs
  • DotNet/Normalization/Domain/Database.cs
  • DotNet/Normalization/Domain/Entities/VendorVersion.cs
  • DotNet/Normalization/Domain/Entities/VendorVersionOperationPreset.cs
  • DotNet/Normalization/Domain/Managers/OperationManager.cs
  • DotNet/Normalization/Domain/Managers/VendorManager.cs
  • DotNet/Normalization/Domain/Managers/VendorVersionOperationPresetManager.cs
  • DotNet/Normalization/Domain/NormalizationDbContext.cs
  • DotNet/Normalization/Domain/Queries/OperationQueries.cs
  • DotNet/Normalization/Domain/Queries/OperationSequenceQueries.cs
  • DotNet/Normalization/Domain/Queries/VendorQueries.cs
  • DotNet/Normalization/Domain/Queries/VendorVersionOperationPresetQueries.cs
  • DotNet/Normalization/Domain/Repositories/VendorRepository.cs
  • DotNet/Normalization/Domain/Repositories/VendorVersionRepository.cs
  • DotNet/Normalization/Domain/Services/VendorVersionResolver.cs
  • DotNet/Normalization/Migrations/20260803184122_RemoveVendorAndVendorVersion.Designer.cs
  • DotNet/Normalization/Migrations/20260803184122_RemoveVendorAndVendorVersion.cs
  • DotNet/Normalization/Migrations/NormalizationDbContextModelSnapshot.cs
  • DotNet/Normalization/Normalization.csproj
  • DotNet/Normalization/Program.cs
  • DotNet/Normalization/packages.lock.json
  • DotNet/ServiceTests/IntegrationTests/Normalization/NormalizationIntegrationTestFixture.cs
  • DotNet/ServiceTests/IntegrationTests/Normalization/OperationTests.cs
  • DotNet/ServiceTests/IntegrationTests/Normalization/VendorTests.cs
  • DotNet/ServiceTests/IntegrationTests/Normalization/VendorVersionOperationPresetTests.cs
  • DotNet/ServiceTests/IntegrationTests/Tenant/FacilityControllerTests.cs
  • DotNet/ServiceTests/IntegrationTests/Tenant/TenantIntegrationTestFixture.cs
  • DotNet/ServiceTests/IntegrationTests/Tenant/VendorControllerTests.cs
  • DotNet/ServiceTests/IntegrationTests/Tenant/VendorManagerTests.cs
  • DotNet/ServiceTests/UnitTests/AutomationUI/ApiEndPointLibraryTests.cs
  • DotNet/ServiceTests/UnitTests/LinkSdk/FacilityServiceClientTests.cs
  • DotNet/ServiceTests/UnitTests/Normalization/OperationModelTests.cs
  • DotNet/ServiceTests/packages.lock.json
  • DotNet/Shared/Application/Enums/Vendor.cs
  • DotNet/Shared/Application/Filters/ValidateAntiForgeryOrBearerTokenAttribute.cs
  • DotNet/Shared/Application/Models/Integration/Normalization/NormalizationApiModels.cs
  • DotNet/Shared/Application/Models/Tenant/CreateVendorModel.cs
  • DotNet/Shared/Application/Models/Tenant/CreateVendorVersionModel.cs
  • DotNet/Shared/Application/Models/Tenant/FacilityModel.cs
  • DotNet/Shared/Application/Models/Tenant/UpdateVendorModel.cs
  • DotNet/Shared/Application/Models/Tenant/UpdateVendorVersionModel.cs
  • DotNet/Shared/Application/Models/Tenant/VendorModel.cs
  • DotNet/Shared/Application/Models/Tenant/VendorVersionModel.cs
  • DotNet/Tenant/Business/Managers/FacilityManager.cs
  • DotNet/Tenant/Business/Managers/VendorManager.cs
  • DotNet/Tenant/Business/Models/FacilitySearchModel.cs
  • DotNet/Tenant/Business/Queries/FacilityQueries.cs
  • DotNet/Tenant/Business/Queries/VendorQueries.cs
  • DotNet/Tenant/Controllers/FacilityController.cs
  • DotNet/Tenant/Controllers/VendorController.cs
  • DotNet/Tenant/Controllers/VendorVersionController.cs
  • DotNet/Tenant/Data/Entities/Facility.cs
  • DotNet/Tenant/Data/Entities/Vendor.cs
  • DotNet/Tenant/Data/Entities/VendorVersion.cs
  • DotNet/Tenant/Data/Repository/Mappings/FacilityConfigMap.cs
  • DotNet/Tenant/Data/Repository/TenantDbContext.cs
  • DotNet/Tenant/Migrations/20260728141251_addVendor.Designer.cs
  • DotNet/Tenant/Migrations/20260728141251_addVendor.cs
  • DotNet/Tenant/Migrations/TenantDbContextModelSnapshot.cs
  • DotNet/Tenant/Program.cs
  • DotNet/Tenant/Tenant.csproj
  • DotNet/Tenant/appsettings.Docker.json
  • DotNet/Tenant/packages.lock.json
  • Tests/BackendE2ETests/packages.lock.json
  • Web/Admin.UI/src/app/components/data-acquisition/reporting-organization-config-dialog/reporting-organization-config-dialog.component.ts
  • Web/Admin.UI/src/app/components/data-acquisition/reporting-organization-config-form/reporting-organization-config-form.component.html
  • Web/Admin.UI/src/app/components/data-acquisition/reporting-organization-config-form/reporting-organization-config-form.component.spec.ts
  • Web/Admin.UI/src/app/components/data-acquisition/reporting-organization-config-form/reporting-organization-config-form.component.ts
  • Web/Admin.UI/src/app/components/normalization/operations/code-map/code-map.component.html
  • Web/Admin.UI/src/app/components/normalization/operations/code-map/code-map.component.ts
  • Web/Admin.UI/src/app/components/normalization/operations/conditional-transformation/conditional-transformation.component.html
  • Web/Admin.UI/src/app/components/normalization/operations/conditional-transformation/conditional-transformation.component.ts
  • Web/Admin.UI/src/app/components/normalization/operations/copy-location-alias-to-type-iteratively/copy-location-alias-to-type-iteratively.component.html
  • Web/Admin.UI/src/app/components/normalization/operations/copy-location-alias-to-type-iteratively/copy-location-alias-to-type-iteratively.component.ts
  • Web/Admin.UI/src/app/components/normalization/operations/copy-location/copy-location.component.html
  • Web/Admin.UI/src/app/components/normalization/operations/copy-location/copy-location.component.ts
  • Web/Admin.UI/src/app/components/normalization/operations/copy-property/copy-property.component.html
  • Web/Admin.UI/src/app/components/normalization/operations/copy-property/copy-property.component.ts
  • Web/Admin.UI/src/app/components/normalization/operations/operations-sequence/operations-sequence.component.ts
  • Web/Admin.UI/src/app/components/normalization/operations/remove-extensions/remove-extensions-csv-import-dialog/remove-extensions-csv-import-dialog.component.ts
  • Web/Admin.UI/src/app/components/normalization/operations/remove-extensions/remove-extensions.component.html
  • Web/Admin.UI/src/app/components/normalization/operations/remove-extensions/remove-extensions.component.ts
  • Web/Admin.UI/src/app/components/tenant/facility-config-form/facility-config-form.component.html
  • Web/Admin.UI/src/app/components/tenant/facility-config-form/facility-config-form.component.spec.ts
  • Web/Admin.UI/src/app/components/tenant/facility-config-form/facility-config-form.component.ts
  • Web/Admin.UI/src/app/components/tenant/facility-edit/facility-edit.component.ts
  • Web/Admin.UI/src/app/components/tenant/global-operations/global-operations-search.component.ts
  • Web/Admin.UI/src/app/components/tenant/tenant-dashboard/tenant-dashboard.component.html
  • Web/Admin.UI/src/app/components/tenant/tenant-dashboard/tenant-dashboard.component.ts
  • Web/Admin.UI/src/app/interfaces/normalization/operation-get-model.interface.ts
  • Web/Admin.UI/src/app/interfaces/normalization/operation-save-model.interface.ts
  • Web/Admin.UI/src/app/interfaces/tenant/facility-config-model.interface.ts
  • Web/Admin.UI/src/app/interfaces/tenant/vendor-interface.ts
  • Web/Admin.UI/src/app/interfaces/tenant/vendor.enum.ts
  • Web/Admin.UI/src/app/services/gateway/normalization/operation.service.spec.ts
  • Web/Admin.UI/src/app/services/gateway/normalization/operation.service.ts
  • Web/Admin.UI/src/app/services/gateway/tenant/tenant.service.service.spec.ts
  • Web/Admin.UI/src/app/services/gateway/tenant/tenant.service.ts

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread DotNet/Tenant/Controllers/VendorController.cs Fixed
Comment thread DotNet/Tenant/Controllers/VendorVersionController.cs Fixed

@arianamihailescu arianamihailescu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@johnbritton
johnbritton merged commit 8d260c6 into dev Aug 4, 2026
18 checks passed
@johnbritton
johnbritton deleted the users/jbritton/LEGLINK-743 branch August 4, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants