Skip to content

LEGLINK-840: Enhance Quick Launch and Scenario Page with Search, Grouping, and Filtering - #1792

Merged
nvmLantana merged 18 commits into
devfrom
LEGLINK-840
Aug 7, 2026
Merged

LEGLINK-840: Enhance Quick Launch and Scenario Page with Search, Grouping, and Filtering#1792
nvmLantana merged 18 commits into
devfrom
LEGLINK-840

Conversation

@SaraMunich-Lantana

@SaraMunich-Lantana SaraMunich-Lantana commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🛠️ Description of Changes

I added in a search bar for both the scenarios page and quick launch that included sorting for alphabetical or by when the scenarios were last updated.

🧪 Testing Performed

I ran end to end testing to make sure that the search and sorting for the search worked for both the scenarios page and the quick launch

🧑‍🔬 Unit Testing

  • Coverage: 0.0%

N/A

📓 Documentation Updated

N/A

Summary by CodeRabbit

  • New Features

    • Added searchable, filterable, and sortable scenario lists.
    • Improved Quick Launch with scenario search, type filtering, sorting, grouped options, and no-results messaging.
    • Scenario selections now update run details and remain synchronized with form submissions.
    • Saving scenarios now immediately updates available launch options.
  • Bug Fixes

    • Custom scenario runs now load complete scenario data and provide clear handling when a selected scenario is unavailable.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6a75fa15-7389-42ed-8552-020fb5d4b1e6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Changes

Scenario management and launch

Layer / File(s) Summary
Scenario list filtering and sorting
DotNet/Automation.UI/Views/Scenarios/Index.cshtml
The scenarios page adds search, type filtering, alphabetical or recent-update sorting, responsive rows, and no-results handling.
Quick Launch scenario selection
DotNet/Automation.UI/Views/Runs/Index.cshtml
Quick Launch now uses a searchable, grouped Bootstrap dropdown with filtering, sorting, hidden-select synchronization, and saved-scenario updates.
Persisted custom scenario startup
DotNet/Automation.UI/Controllers/RunsController.cs, DotNet/Automation.UI/Controllers/ScenariosController.cs
Custom runs load the persisted scenario before startup and retain missing-scenario handling. SaveInline also receives a whitespace-only change.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Suggested reviewers: nvmlantana, davey-poot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the search, grouping, and filtering enhancements for Quick Launch and the Scenarios page.
Description check ✅ Passed The description includes all required sections and accurately reports the implemented features, end-to-end testing, lack of unit tests, and documentation status.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch LEGLINK-840

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
DotNet/Automation.UI/Controllers/RunsController.cs (1)

153-170: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add focused XUnit tests for custom scenario startup.

Use Moq for IScenarioStore and IAutomationRunManager. Verify that a valid scenario starts with persisted scenario values. Verify that a missing scenario redirects with RunStartError and does not call StartAsync.

As per path instructions, “If/Else ... blocks are introduced or modified — ensure each branch has a corresponding unit test,” and “No network activity ... should appear in unit tests. Recommend using mocks (via Moq).”

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@DotNet/Automation.UI/Controllers/RunsController.cs` around lines 153 - 170,
Add focused XUnit tests for the custom-scenario branch in RunsController, using
Moq mocks for IScenarioStore and IAutomationRunManager. Verify a found scenario
passes its persisted values to StartAsync, and a missing scenario redirects to
Index, sets TempData["RunStartError"], and does not invoke StartAsync. Keep the
tests isolated from network activity.

Source: Path instructions

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@DotNet/Automation.UI/Views/Runs/Index.cshtml`:
- Around line 827-895: Update the scenario-editor:changed handler to obtain the
complete persisted scenario metadata after a save, since SaveInline provides
only the id. Use the loaded name, description, method, measures, type, and
persisted UpdatedAt to update both the hidden option and visible quick-launch
button, including existing options rather than only new ones. Ensure sorting
uses the persisted UpdatedAt value before refreshing search and selection.

In `@DotNet/Automation.UI/Views/Scenarios/Index.cshtml`:
- Around line 231-234: Update the no-results visibility logic near noResults so
the filter empty state is shown only when rows.length is greater than zero and
visibleCount is zero; keep it hidden when no scenarios exist, while preserving
the existing behavior when matching rows are available.

---

Nitpick comments:
In `@DotNet/Automation.UI/Controllers/RunsController.cs`:
- Around line 153-170: Add focused XUnit tests for the custom-scenario branch in
RunsController, using Moq mocks for IScenarioStore and IAutomationRunManager.
Verify a found scenario passes its persisted values to StartAsync, and a missing
scenario redirects to Index, sets TempData["RunStartError"], and does not invoke
StartAsync. Keep the tests isolated from network activity.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c3021a9f-9ea9-4eff-84ac-e7df035500f3

📥 Commits

Reviewing files that changed from the base of the PR and between 642558b and 0f878c5.

📒 Files selected for processing (4)
  • DotNet/Automation.UI/Controllers/RunsController.cs
  • DotNet/Automation.UI/Controllers/ScenariosController.cs
  • DotNet/Automation.UI/Views/Runs/Index.cshtml
  • DotNet/Automation.UI/Views/Scenarios/Index.cshtml

Comment thread DotNet/Automation.UI/Views/Runs/Index.cshtml Outdated
Comment thread DotNet/Automation.UI/Views/Scenarios/Index.cshtml
SaraMunich-Lantana and others added 5 commits August 5, 2026 14:34
… Launch metadata after each save. Both the hidden option and visible dropdown item are now refreshed with the saved name, description, report method, measures, scenario type, and UpdatedAt value before re-sorting and reapplying the active search/filter state.

@nvmLantana nvmLantana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nvmLantana
nvmLantana merged commit 9f2bdc7 into dev Aug 7, 2026
18 checks passed
@nvmLantana
nvmLantana deleted the LEGLINK-840 branch August 7, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants