LEGLINK-654: Update downstream submission logic to use submittable validation categories

[johnbritton]

🛠️ Description of Changes

Change pre-qualification OperationOutcome to be built from categories with submit==true instead of unacceptable (acceptable==false). Updated PreQualOperationOutcomeBuilder logic and javadoc, adjusted ReadyForValidationConsumer javadoc, and revised tests to use Category.submit (added helper overloads and updated expectations). This aligns pre-qual behavior with the requirement to include only submitted categories (LEGLINK-425) and updates unit tests accordingly.

🧪 Testing Performed

Turned on OperationOutcome export and observed it included only issues where submit==true.

🧑‍🔬 Unit Testing

• I have written or updated unit tests to cover my changes
• Coverage: 100.0%

📓 Documentation Updated

Please update any relevant sections in the project documentation that were impacted by the changes in the PR.

Summary by CodeRabbit

• Bug Fixes
  • Pre-qualification validation outcomes now include findings from submitted categories, including submitted categories that are otherwise acceptable.
  • Non-submitted category findings are excluded from generated outcomes.
  • Pre-qualification results are appended consistently across existing, fetched, unrelated, and missing-resource scenarios.
  • Empty outcomes are produced when no categories are submitted.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 340e5772-8d08-4120-83d2-b08a7aa03515

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b3092158-29f3-4aad-acbf-91cad790e15b

📥 Commits

Reviewing files that changed from the base of the PR and between db5a7bf and 42714d1.

📒 Files selected for processing (4)

• Java/validation/src/main/java/com/lantanagroup/link/validation/services/PreQualOperationOutcomeBuilder.java
• Java/validation/src/main/java/com/lantanagroup/link/validation/services/ReadyForValidationConsumer.java
• Java/validation/src/test/java/com/lantanagroup/link/validation/services/PreQualOperationOutcomeBuilderTest.java
• Java/validation/src/test/java/com/lantanagroup/link/validation/services/ReadyForValidationConsumerTest.java

---

📝 Walkthrough

Walkthrough

The validation flow now creates and appends pre-qualification findings for categories with submit=true. Tests cover submitted, non-submitted, mixed, empty, duplicate, unrelated, and missing-resource scenarios.

Changes

Submitted category findings

Layer / File(s)	Summary
Submission-based outcome filtering Java/validation/src/main/java/com/lantanagroup/link/validation/services/PreQualOperationOutcomeBuilder.java, Java/validation/src/main/java/com/lantanagroup/link/validation/services/ReadyForValidationConsumer.java	PreQualOperationOutcomeBuilder includes categories with submit=true. Related documentation describes submitted-category findings.
Submission behavior validation Java/validation/src/test/java/com/lantanagroup/link/validation/services/PreQualOperationOutcomeBuilderTest.java, Java/validation/src/test/java/com/lantanagroup/link/validation/services/ReadyForValidationConsumerTest.java	Tests cover submitted categories, non-submitted categories, mixed results, empty outcomes, append conditions, duplicate prevention, unrelated outcomes, and missing resources.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: ⚪ Minimal · up to 42714

The PR updates pre-qualification outcomes to include only submitted categories and adjusts the related tests and documentation; no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

• lantanagroup/link-cloud#1816: Uses the validation category submit flag for pre-qualification findings and outcomes.
• lantanagroup/link-cloud#1824: Updates ReadyForValidationConsumer and related tests to use category submission status.

Suggested reviewers: mikeatpinnacle, seanmcilvenna

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the downstream submission logic change and the use of submittable validation categories.
Description check	✅ Passed	The description covers the changes, testing, unit-test coverage, and documentation section; it is mostly complete.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch users/jbritton/LEGLINK-654

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}