[8.x] Me again, with assertAcceptingDialog/Dismissing() - #1197
Closed
weshooper wants to merge 3 commits into
Closed
Conversation
I know we must wait for dialogs, but don't wanna read all about it in our tests. Maybe other Dusk aficionados feel the same? 🤓
Member
|
The naming makes me think I'm asserting some previous action, but the method actually accepts the dialog actively. |
taylorotwell
marked this pull request as draft
April 15, 2026 13:31
weshooper
changed the title
assertDialogAccepted/Dismissed()assertAcceptingDialog/Dismissing()
weshooper
marked this pull request as ready for review
April 15, 2026 13:51
Contributor
Author
|
I've renamed to be more active. |
Member
|
Hmm, I dunno, I may skip this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know we must wait for dialogs, but don't wanna read all about it in our tests.
Maybe other Dusk aficionados feel the same? 🤓
No tests as super boring proxies, that I pinky promise to add to docs...