[8.x] Change clickOnce methods to clickWhen - #1198
Merged
Merged
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
jackbayliss
changed the title
jackbayliss
marked this pull request as ready for review
April 15, 2026 14:11
Contributor
|
Outrageous 🤣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just got merged, but I think "when" fits better, and fits existing consistency like
whenAvailableandelsewhereWhenAvailableso thought I'd try a super fast PR.This just got merged, so no b/c as not public yet 🥳
This means:
clickOnceEnabledbecomesclickWhenEnabledclickOnceVisiblebecomesclickWhenVisibleThe guy who just got it merged is my boss, so I am trudging in deep waters, pray for me. (im serious)