Open
Conversation
NTrevisani
reviewed
Nov 11, 2025
|
|
||
| if framework_path: | ||
| if "Full20" in era: | ||
| key = era.split("Full20")[1].split("v")[0] |
There was a problem hiding this comment.
Is key defined only here? I.e. Can it be used in line 57?
Does this if handle also the 2016 case, where if I remember correctly, we split into 2016HIPM and 2016noHIPM (without Full)?
Author
There was a problem hiding this comment.
I have not tested yet on 2016, but I will need to do it soon and let you know.
The "key" was there in the code before ... not sure why/where it was introduced
There was a problem hiding this comment.
Thank you. Then, I would wait for the 2016 test before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit for back compatibility with Run 2 settings.
It's important to have both run 2 and run 3, since most likely analyses will have to handle both dataset.