fix #116 allow backup directory with spaces#118
Open
Wikinaut wants to merge 1 commit intolaurent22:masterfrom
Open
fix #116 allow backup directory with spaces#118Wikinaut wants to merge 1 commit intolaurent22:masterfrom
Wikinaut wants to merge 1 commit intolaurent22:masterfrom
Conversation
Owner
|
It seems the pull request sometimes adds two pairs of double quotes, and sometimes one pair of double and one pair single quotes. For example: That would result in: Is there any reason for this? Edit: Sorry just saw you haven't tested it, but obviously this needs to be tested as we don't want to break people's backup scripts. |
|
+1. For me that has solved the problem. ( directory with spaces in destination backup dir) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@laurent22 here's a formal PR. Attention: I haven't tested it!