Skip to content

Use docile to simplify dsl setup#14

Open
timolehto wants to merge 2 commits into
lautis:masterfrom
timolehto:use_docile
Open

Use docile to simplify dsl setup#14
timolehto wants to merge 2 commits into
lautis:masterfrom
timolehto:use_docile

Conversation

@timolehto

Copy link
Copy Markdown

Using Docile https://github.com/ms-ati/docile instead of cooking our own DSL building logic would have some benefits:

  • Maybe more standard DSL as other libraries also use it.. e.g. at lest pena already has docile as some of its gems dependencies.
  • A few less lines for piperator to maintain as Builder now significantly simplified
  • In addition to current things we can do with DSL would also allow referencing instance variables, albeit setting the variables from nested blocks is not possible, so in piperators case e.g. a @counter can not really be used

On the other hand it's an extra dependency to a small utility library which so far has had none. I can certainly see the appeal in keeping things that way. Also the instance variable handling has raised some concerns ms-ati/docile#37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant