Update api query params#186
Merged
Merged
Conversation
Signed-off-by: Raunak Madan <madanraunak24@gmail.com>
github-actions
Bot
added
area/learning-paths
area/challenges
area/certifications
labels
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the registry URL construction in the Hugo partial to include a status filter. A suggestion was made to use the built-in querify function for more robust and idiomatic query string construction, ensuring proper URL encoding for parameters.
| {{- else -}} | ||
| {{- $separator := cond (in $registryURL "?") "&" "?" -}} | ||
| {{- $url := printf "%s%sorgId=%s" $registryURL $separator $orgID -}} | ||
| {{- $url := printf "%s%sorgId=%s&status=ready,not_ready" $registryURL $separator $orgID -}} |
Contributor
There was a problem hiding this comment.
Using Hugo's built-in querify function is a more robust and idiomatic way to construct query strings compared to manual concatenation. It automatically handles URL encoding for all parameter values, which prevents potential bugs if $orgID contains characters that require escaping.
Suggested change
| {{- $url := printf "%s%sorgId=%s&status=ready,not_ready" $registryURL $separator $orgID -}} | |
| {{- $url := printf "%s%s%s" $registryURL $separator (querify "orgId" $orgID "status" "ready,not_ready") -}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #
Signed commits