Skip to content

fix(docs): make content width consistent#1152

Open
Sbragul26 wants to merge 1 commit into
layer5io:masterfrom
Sbragul26:fix/docs-content-width
Open

fix(docs): make content width consistent#1152
Sbragul26 wants to merge 1 commit into
layer5io:masterfrom
Sbragul26:fix/docs-content-width

Conversation

@Sbragul26

Copy link
Copy Markdown
Member

Notes for Reviewers

This PR fixes #1145 by making the content width consistent across the affected documentation pages.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Sbragul26 <sbragul26@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the max-width constraints ($site-max-width) from the footer, navigation bar, and main content areas. The feedback highlights that removing these constraints will cause elements to stretch infinitely on large or ultrawide screens, which degrades readability and layout consistency. It is recommended to retain these constraints globally and use specific classes to opt-out where full-width layouts are explicitly needed.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

I am having trouble creating individual review comments. Click here to see my feedback.

assets/scss/_styles_project.scss (772-788)

medium

Removing the global max-width constraint ($site-max-width) to achieve consistency will cause the documentation content and navigation bar to stretch infinitely on large or ultrawide screens. This significantly degrades readability due to excessively long line lengths for text. Instead of removing these constraints globally, consider keeping them for standard documentation pages and using a specific class (e.g., .full-width or page-specific classes like .td-home) to opt-out of the max-width constraint where a full-width layout is actually desired.

assets/scss/_footer_project.scss (14-19)

medium

Similar to the main content area, removing the max-width constraint from the footer elements will cause them to stretch to the far edges of large screens, leading to an inconsistent and disjointed layout compared to the rest of the page content. It is recommended to retain the max-width constraint to ensure the footer content remains aligned with the main content container.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Preview deployment: https://docs.layer5.io/pr-preview/pr-1152/

Note: Preview may take a moment (GitHub Pages deployment in progress). Please wait and refresh. Track deployment here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs] Inconsistent content width across multiple documentation pages

1 participant