[UI] : Add tooltips to footer social media icons#7747
Conversation
Signed-off-by: Maanvi Chetwani <maanvichetwani21@gmail.com>
|
🚀 Preview deployment: https://layer5.io/pr-preview/pr-7747/
|
Rajesh-Nagarajan-11
left a comment
There was a problem hiding this comment.
Use custom tooltip from @sistent/sistent
Signed-off-by: Maanvi Chetwani <maanvichetwani21@gmail.com>
|
Also, I noticed that |
Sounds good, give it a try. |
|
LGTM |
|
@Maanvi212006 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
Rajesh-Nagarajan-11
left a comment
There was a problem hiding this comment.
Could be please reduce the size of the tooltip as currently it feels oversized
Signed-off-by: Maanvi Chetwani <maanvichetwani21@gmail.com>
Signed-off-by: Maanvi Chetwani <maanvichetwani21@gmail.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds hover tooltips to each footer social icon using CustomTooltip from @sistent/sistent, improving discoverability of what each icon/link represents.
Changes:
- Imported and used
CustomTooltipto wrap each social link icon in the footer. - Added per-platform tooltip text (title) for each icon link.
Comments suppressed due to low confidence (1)
src/components/SocialLinks-Color/index.js:1
- Icon-only links need an accessible name that screen readers can announce. Tooltips generally aren’t a reliable accessible-name source, and the X/Twitter link uses an SVG component (
<TwitterIcon />) which may end up with no readable label. Add anaria-label(or visually hidden text) on each<a>so every social link has a clear, descriptive accessible name (e.g., “Follow Layer5 on X (Twitter)”, “Layer5 on GitHub”, etc.).
import React from "react";
| <CustomTooltip title="Email Layer5 Community" placement="top" variant="small"> | ||
| <a className="mail_icon" | ||
| href="mailto:community@layer5.io" | ||
| target="_blank" | ||
| rel="noreferrer" | ||
| > | ||
| <img height="30px" src={mail_icon} alt="mail" /> | ||
| </a> | ||
| </CustomTooltip> |
|
Worth considering copilot's suggestions |
Signed-off-by: Maanvi Chetwani <maanvichetwani21@gmail.com>
Description
Added tooltips to all social media/platform icons in the footer using CustomTooltip from @sistent/sistent
This PR fixes #7746
Notes for Reviewers
src/components/SocialLinks-Color/index.jsreact-tooltipis already a dependency in the project — no new packages addedSigned commits