Align contained header with contained page content - #100
Merged
Conversation
Move the page gutter from .l-ui-header onto .l-ui-header-container so the gutter sits outside the width cap on both the header and .l-ui-page__contained. The contained header now caps its content at --l-ui-contained-width within the same gutter-inset frame as the page column, so the two align by construction.
ReviewMoves the page gutter ( ✅ Ship - Clean, correct fix with no regressions; the structural change is sound and the alignment is now consistent by construction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the page gutter from .l-ui-header onto .l-ui-header-container so the gutter sits outside the width cap on both the header and .l-ui-page__contained. The contained header now caps its content at --l-ui-contained-width within the same gutter-inset frame as the page column, so the two align by construction.