0.6.0

[thomasgallagher]

No description provided.

[claude]

Review

Moves the "Agent skill" section earlier in both README.md and the dummy app home page (before Requirements), and adds rel="noopener noreferrer" to the external agentskills.io link in the ERB view.

No issues found.

✅ Ship - Pure documentation reorganisation with a small security improvement (rel="noopener noreferrer" on the external link).

[claude]

Review

This PR renames PaginationHelper to PagyHelper (better reflecting its purpose) and moves the agent skill section earlier in the README and dummy app home page.

No issues found. All references are updated consistently: the helper file, module name, engine registration, test file, test class, and documentation all align.

✅ Ship - clean rename with no loose ends.

[claude]

Review

This PR consolidates two renames for the 0.6.0 release: --surface-active → --surface-highlight (CSS token and all class names), and PaginationHelper → PagyHelper (Ruby module, file, and test). It also moves the agent skill section earlier in the README and dummy app home page.

All usages are consistently updated across CSS, Ruby, views, tests, documentation pages, and skill reference files. No issues found.

✅ Ship

[claude]

Review: 0.6.0

Bundles two breaking renames - --surface-active → --surface-highlight (CSS token and BEM classes) and PaginationHelper → PagyHelper (module and file) - alongside documentation improvements and repositioning of the agent skill section.

The renames are applied consistently across CSS, generator templates, engine registration, helper files, tests, dummy app views, and skill references. No stale references to the old names are visible in the diff.

✅ Ship

[claude]

Review: PR #38 - 0.6.0 release

This PR bundles the 0.6.0 release: renames → (CSS token and BEM classes), removes the colour token in favour of blur-only backdrops, renames → , and moves the agent skill section earlier in the README. All changes are consistently applied across CSS, helpers, tests, generators, and documentation.

No issues found. All renames are applied consistently throughout the codebase (CSS variables, utilities, BEM classes, generator templates, dummy app views, test files, and docs). The backdrop colour removal is intentional and matches the already-merged PR #42.

✅ Ship

[claude]

Review

This PR bumps to 0.6.0 with three coordinated breaking changes: rename PaginationHelper → PagyHelper, rename --surface-active / .l-ui-surface--active → --surface-highlight / .l-ui-surface--highlight, and remove the --backdrop token (backdrop is now blur-only). Documentation, tests, generators, and the dummy app are all updated consistently.

No issues found - all renames are applied exhaustively, no stale references remain, and the breaking changes are appropriate for a minor version bump.

✅ Ship

[claude]

Review: 0.6.0

This PR bundles several breaking changes into a 0.6.0 release: renames PaginationHelper → PagyHelper, renames --surface-active / l-ui-surface--active → --surface-highlight / l-ui-surface--highlight, removes the --backdrop token in favour of a blur-only approach, and solidifies floating buttons (removes semi-transparency and shadow).

Issues

Severity	File	Line(s)	Description
MEDIUM	app/assets/tailwind/layered/ui/styles.css	1726-1728	.l-ui-modal::backdrop now only applies backdrop-filter: blur(4px) with no background colour. Chrome renders ::backdrop as fully transparent by default, so the modal backdrop in Chrome will be a see-through blur with no darkening - users lose the visual signal that the page behind is inactive. Firefox applies a semi-transparent black by default, so the appearance diverges significantly across browsers. The previous bg-backdrop/50 ensured consistent darkening. Same applies to .l-ui-backdrop--navigation (line 613-618).

Verdict

🟧 Ship (with known minor issues) - All renames are applied consistently with no orphaned references. The backdrop rendering difference across Chrome and Firefox is the one concrete cross-browser regression worth noting before shipping.

[claude]

Review

This PR prepares the 0.6.0 release: it renames PaginationHelper → PagyHelper, renames the --surface-active/l-ui-surface--active tokens and classes to --surface-highlight/l-ui-surface--highlight, removes the --backdrop colour token in favour of blur-only backdrops, solidifies floating button styles, and updates all documentation and skill references to match.

Issues

Severity	File	Line(s)	Description
HIGH	lib/layered/ui/version.rb	—	Version is still 0.5.0 on the release branch - VERSION was not bumped to 0.6.0 in this PR. Publishing the gem as-is would release the wrong version number.
HIGH	CHANGELOG.md	—	No 0.6.0 entry added. The PR contains several breaking renames (PaginationHelper → PagyHelper, l-ui-surface--active → l-ui-surface--highlight, --surface-active/--backdrop token removals) that upgrading users need to be warned about.

Verdict

🚫 Changes required - The version bump and CHANGELOG entry for 0.6.0 are missing; shipping without them would publish the wrong gem version and leave upgrading users with no record of the breaking changes.

[claude]

This PR bundles the 0.6.0 release: it renames --surface-active → --surface-highlight (token + all CSS classes), removes the --backdrop color token in favour of blur-only backdrops, renames PaginationHelper → PagyHelper, promotes the agent-skill section in the README, adds two-tier color token documentation, and right-aligns the scroll-to-bottom button.

Issues

Severity	File	Line(s)	Description
HIGH	lib/layered/ui/version.rb, CHANGELOG.md	-	Neither file is included in this PR diff. VERSION is still "0.5.0" and there is no ## [0.6.0] section in the changelog, despite this being a release PR with multiple breaking renames (--surface-active, --backdrop, PaginationHelper, l-ui-surface--active). Publishing the gem from this state will tag and ship it as 0.5.0.

Verdict

🚫 Changes required - The version constant and changelog must be updated before this can ship as a 0.6.0 release.

[claude]

Summary

v0.6.0 release: renames --surface-active → --surface-highlight and PaginationHelper → PagyHelper across CSS, Ruby, and views; removes the --backdrop token (backdrop now uses blur-only); adds --button-primary-bg/--button-primary-text as Tier 2 overrides; strips the page param on search/sort form submit; and moves the agent-skill section earlier in the README.

Verdict

✅ Ship - All renames are applied consistently with no dangling references, the JS page-param fix is correct, and no bugs or security issues were found.

[claude]

Summary

Release preparation for 0.6.0: renames --surface-active → --surface-highlight (CSS token + BEM classes), renames PaginationHelper → PagyHelper, removes the --backdrop colour token in favour of blur-only overlays, documents the two-tier theming system (--button-primary-bg/--button-primary-text), and resets the Pagy page param when a Ransack search or sort form submits.

Issues

No issues found. All reference files, docs, dummy app views, and tests are updated consistently with the renamed tokens and helpers.

Verdict

✅ Ship - Changes are coherent and complete across the codebase.

[claude]

Summary

0.6.0 release: renames CSS tokens ( → , removes ), renames to , adds a action to the search-form Stimulus controller for preserving cross-scope pagination params, and adds Pagy pagination to the Ransack integration demo.

Issues

Severity	File	Line(s)	Description
MEDIUM	app/helpers/layered/ui/pagy_helper.rb	(rename)	PaginationHelper is renamed to PagyHelper without a deprecation alias. The engine's helper call in engine.rb is updated, so the auto-included helper path is fine. But any host app that directly references Layered::Ui::PaginationHelper (e.g. custom tests with include Layered::Ui::PaginationHelper, or a module re-open) will get a NameError with no guidance. A one-release deprecation shim (PaginationHelper = PagyHelper) would give users a warning rather than a hard break.

Verdict

🟧 Ship (with known minor issues) - The rename is intentional for 0.6.0 and the impact is narrow (only apps directly referencing the module by name are affected), but documenting the breaking change in release notes or adding a deprecation constant would reduce surprise for upgraders.

[claude]

Review: 0.6.0 release

This PR bumps to 0.6.0, renaming PaginationHelper → PagyHelper and --surface-active → --surface-highlighted across the codebase, adding the rewriteLink action to preserve pagination params across Turbo Frames, removing the --backdrop token in favour of blur-only backdrops, and adding thin scrollbar styling.

Issues

Severity	File	Line(s)	Description
MEDIUM	app/javascript/layered_ui/controllers/l_ui/search_form_controller.js	38-40	rewriteLink merges ALL current URL params into pagination links without filtering commit (or page). #otherParams() explicitly skips commit (line 51) because f.submit renders <input name="commit"> by default, so after a search submission commit=Search is in the URL. Clicking a pagination link then produces ?users_page=2&commit=Search - dirty URLs and inconsistent with the filtering already present in #otherParams(). Fix: add the same commit guard (and page if desired) to the loop in rewriteLink.

Verdict

🟧 Ship (with known minor issue) - The rename, scrollbar, and backdrop changes are clean and well-documented; the commit param leak in rewriteLink is a one-line fix that could follow in a patch release.

[claude]

Summary

Release PR for 0.6.0: renames PaginationHelper → PagyHelper and --surface-active → --surface-highlighted, adds a rewriteLink action to the search-form controller so pagination links inside Turbo Frames carry other scopes' URL params, removes the --backdrop colour token (backdrops are now blur-only), and adds thin scrollbars across the l-ui-body.

Issues

None.

Verdict

✅ Ship - Clean release PR; all renamed identifiers are updated consistently, the rewriteLink logic correctly filters the scope's own page param while injecting other scopes' params, and breaking changes are documented in the changelog.