Header contained modifier and links yield - #83
Merged
Conversation
Introduces l-ui-body--header-contained to constrain the header's inner row to a max-width (via --l-ui-header-max-width, default 80rem) and a :l_ui_header_links yield for inline link lists in the header. Targets landing-page layouts where the header should mirror the page content width and show plain text links instead of sidebar nav.
Drop the --l-ui-header-max-width custom property in favour of max-w-7xl, and wrap the header links yield in a <nav aria-label="Sections"> for better landmark semantics.
Review: Header contained modifier and links yieldAdds a ✅ Ship No issues found - the implementation is consistent with existing patterns, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.