Add header_actions helper and split header partial

[thomasgallagher]

Extracts theme toggle, navigation toggle, and authentication into their own partials, and adds an l_ui_header_actions helper so host apps can append or replace the default header actions.

[claude]

Review: Add header_actions helper and split header partial

Splits the monolithic header partial into three focused sub-partials (, , ) and exposes public helpers for each, plus three new yields (, , ) for host apps to compose the header action area.

Issues

Severity	File	Line(s)	Description
MEDIUM		17, 27	yield(:l_ui_header_actions_start) and yield(:l_ui_header_actions_end) are rendered outside the if/else block, so they render unconditionally - even when :l_ui_header_actions is set to replace the defaults. A host app that sets :l_ui_header_actions_start in a parent layout and later uses :l_ui_header_actions in a child view will see both the _start content and the replaced actions rendered together, with no way to suppress the outer yields. This interaction is undocumented and easy to hit in multi-layout apps. Consider skipping the outer yields when content_for?(:l_ui_header_actions) is true, or document the behaviour explicitly.

Verdict

🟧 Ship (with known minor issues) - The core refactor is clean and well-tested; the only rough edge is the undocumented interaction between :l_ui_header_actions and the _start/_end yields.

[claude]

Review: Add header_actions helper and split header partial

Splits the monolithic header partial into three focused sub-partials (_theme_toggle, _authentication, _navigation_toggle) and exposes public helpers for each, plus three new yields (:l_ui_header_actions, :l_ui_header_actions_start, :l_ui_header_actions_end) for host apps to compose the header action area.

Issues

Severity	File	Line(s)	Description
MEDIUM	app/views/layouts/layered_ui/_header.html.erb	17, 27	yield(:l_ui_header_actions_start) and yield(:l_ui_header_actions_end) are rendered outside the if/else block, so they render unconditionally - even when :l_ui_header_actions is set to replace the defaults. A host app that sets :l_ui_header_actions_start in a parent layout and later uses :l_ui_header_actions in a child view will see both the _start content and the replaced actions rendered together, with no way to suppress the outer yields. This interaction is undocumented and easy to hit in multi-layout apps. Consider skipping the outer yields when content_for?(:l_ui_header_actions) is true, or document the behaviour explicitly.

Verdict

🟧 Ship (with known minor issues) - The core refactor is clean and well-tested; the only rough edge is the undocumented interaction between :l_ui_header_actions and the _start/_end yields.

[claude]

Review

Extracts the theme toggle, authentication buttons, and navigation toggle out of _header.html.erb into their own partials, then surfaces them as l_ui_theme_toggle, l_ui_authentication, and l_ui_navigation_toggle helpers. Adds three header-action yield points (:l_ui_header_actions_start, :l_ui_header_actions_end, :l_ui_header_actions) so host apps can compose or replace the default action bar without overriding the full partial.

No issues found.

✅ Ship