Expand l_ui_form field types and add multipart override - #86
Conversation
Add tel, url, search, time, month, week, color, range, and file to the supported field types so l_ui_form covers the HTML5 input types modern browsers expect. Map :tel to telephone_field since Rails has no tel_field. Add a multipart: option that overrides the auto-detection (true when any field is :file). Document the override-the-partial escape hatch in the skill reference and dummy app docs.
ReviewAdds HTML5 input types (, , , , , , , , ) to , maps to Rails' , and introduces a override with auto-detection when any field is . Issues
Verdict🟧 Ship (with known minor issues) - The feature is correct and the bug is latent (unreachable via the public helper), but should be fixed before the guard logic gives a future maintainer a misleading safety net. |
Review: Expand l_ui_form field types and add multipart overrideAdds nine new HTML5 input types to Issues
Verdict🚫 Changes required - The implementation is correct, but the project's own conventions require live dummy-app examples and test coverage for the new field types. |
Add tests for all new field types (password, tel, url, search, time, month, week, color, range, file) including the :tel → telephone_field mapping, plus multipart auto-detection coverage. Expand the dummy app's "All field types" example to render every supported type.
ReviewAdds , , , , , , , , and to the supported No issues found. The whitelist validation in ✅ Ship |
Add tel, url, search, time, month, week, color, range, and file to the supported field types so l_ui_form covers the HTML5 input types modern browsers expect. Map :tel to telephone_field since Rails has no tel_field.
Add a multipart: option that overrides the auto-detection (true when any field is :file). Document the override-the-partial escape hatch in the skill reference and dummy app docs.