Tokenise page gutter and add .l-ui-bleed full-bleed utility - #91
Merged
Conversation
Introduce --l-ui-gutter (default 1rem) as the single source for the page's horizontal/bottom padding and the breathing-room part of the top offset, and bind .l-ui-header to the same token so the page and header gutters can no longer drift. Add .l-ui-bleed, which cancels exactly the current gutter to take a child edge-to-edge without negative-margin guesswork. Computed values are unchanged (non-breaking). Document both in the skill reference and the dummy app utilities page. Also clarify that .l-ui-page__width-constrained is a narrow ~384px auth-card column, not a general page container.
ReviewTokenises the page gutter into a ✅ Ship - Clean, non-breaking tokenisation with correct semantics and complete documentation. |
The old name read as a general page-width container, so it was reached for to bound arbitrary page content and then imposed a 384px straitjacket. The class is actually a narrow (md:max-w-sm, ~384px) column for auth cards and compact forms. Rename to .l-ui-page__narrow and trim the defensive docs the misleading name required. Breaking change (pre-release): documented in CHANGELOG and UPGRADING. Updates the six Devise views, engine CSS, and skill reference.
|
This PR tokenises the page horizontal/bottom padding into a No issues found. A few things I checked specifically:
✅ Ship |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce --l-ui-gutter (default 1rem) as the single source for the page's horizontal/bottom padding and the breathing-room part of the top offset, and bind .l-ui-header to the same token so the page and header gutters can no longer drift. Add .l-ui-bleed, which cancels exactly the current gutter to take a child edge-to-edge without negative-margin guesswork. Computed values are unchanged (non-breaking).
Document both in the skill reference and the dummy app utilities page.
Also clarify that .l-ui-page__width-constrained is a narrow ~384px column for compact / centred content, not a general page container.