Skip to content

Make small icon buttons square (32px) instead of 44px wide - #92

Merged
thomasgallagher merged 2 commits into
mainfrom
fix-small-icon-button-width
Jun 7, 2026
Merged

Make small icon buttons square (32px) instead of 44px wide#92
thomasgallagher merged 2 commits into
mainfrom
fix-small-icon-button-width

Conversation

@thomasgallagher

Copy link
Copy Markdown
Collaborator

Combining l-ui-button--icon with l-ui-button--small left the button 44px wide because --small only shrank the height. Add a combined modifier so a small icon button becomes a 32px square, still above the WCAG 2.2 AA 24px target-size minimum.

Document the variant in the dummy app buttons page and the skill CSS reference.

Combining l-ui-button--icon with l-ui-button--small left the button
44px wide because --small only shrank the height. Add a combined
modifier so a small icon button becomes a 32px square, still above
the WCAG 2.2 AA 24px target-size minimum.

Document the variant in the dummy app buttons page and the skill
CSS reference.
@claude

claude Bot commented Jun 7, 2026

Copy link
Copy Markdown

Review

Adds a compound CSS modifier so combining l-ui-button--icon and l-ui-button--small produces a 32px square hit area instead of the previous 44×32px rectangle, and documents the variant in the dummy app and skill reference.

The implementation is correct. The compound selector .l-ui-button--icon.l-ui-button--small (specificity 0,2,0) properly wins over both single-class selectors, min-w-[32px] overrides the min-w-[44px] from --icon, and p-1.5 overrides both p-2 (from --icon) and px-3 (from --small). The min-h-[32px] from --small carries through unaffected, giving a correct 32px square.

Ship

@claude

claude Bot commented Jun 7, 2026

Copy link
Copy Markdown

Review

Adds a combined CSS modifier to produce a 32px square icon button, and applies it to the panel close button.

The implementation is correct: the compound selector carries higher specificity than either single-class rule, so cleanly overrides from --icon, and p-1.5 overrides p-2. Height is handled by the existing --small rule (min-h-[32px]), so no duplication is needed in the combined rule.

WCAG 2.2 AA compliance is retained (32px > 24px minimum). Dummy app docs follow the established heading/description/live-example/modal pattern.

Ship

@thomasgallagher
thomasgallagher merged commit 9096b40 into main Jun 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant