Animate sub navigation items - #93
Merged
thomasgallagher merged 2 commits intoJun 7, 2026
Merged
Conversation
…n load Restored open/closed state was animating the section chevron on page load. Apply a temporary --no-transition modifier while setting the initial aria-expanded state, then remove it after two animation frames so the chevron renders in position without animating.
ReviewThis PR adds a slide-down animation for navigation section items when a user opens a section, and suppresses the chevron's CSS transition when restoring open/closed state from Issues
Verdict🚫 Changes required - the |
|
PR adds a slide-in animation for navigation section items on user-initiated open, and suppresses the chevron transition when restoring saved open/closed state on page load. The implementation is clean. A few things I verified:
No issues found. ✅ Ship |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppress chevron transition when restoring navigation section state on load.
Restored open/closed state was animating the section chevron on page load. Apply a temporary --no-transition modifier while setting the initial aria-expanded state, then remove it after two animation frames so the chevron renders in position without animating.