Document available icon names and clarify icon: usage - #95
Merged
Conversation
Clarify that icon: resolves to layered_ui/icon_NAME.svg and that an unknown name raises Propshaft::MissingAssetError. List the icons that ship with the gem (correcting the prior claim that only "home" did), and add an Available icons section to the dummy app showing the general-purpose set. Internal-UI chrome icons (mask shapes / baked theme colours) are noted as not usable via icon:.
ReviewDocumentation-only PR that corrects and expands the icon reference: clarifies the behaviour, lists all icons that ship with the gem (previously just "home" was documented), distinguishes general-purpose from internal-chrome icons, and adds a visual Available icons section to the dummy app. Verified: all 8 general-purpose icon names listed in HELPERS.md have corresponding No issues found. ✅ Ship |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that icon: resolves to layered_ui/icon_NAME.svg and that an unknown name raises Propshaft::MissingAssetError. List the icons that ship with the gem (correcting the prior claim that only "home" did), and add an Available icons section to the dummy app showing the general-purpose set. Internal-UI chrome icons (mask shapes / baked theme colours) are noted as not usable via icon:.