Skip to content

Document available icon names and clarify icon: usage - #95

Merged
thomasgallagher merged 1 commit into
mainfrom
docs/clarify-icon-usage
Jun 7, 2026
Merged

Document available icon names and clarify icon: usage#95
thomasgallagher merged 1 commit into
mainfrom
docs/clarify-icon-usage

Conversation

@thomasgallagher

Copy link
Copy Markdown
Collaborator

Clarify that icon: resolves to layered_ui/icon_NAME.svg and that an unknown name raises Propshaft::MissingAssetError. List the icons that ship with the gem (correcting the prior claim that only "home" did), and add an Available icons section to the dummy app showing the general-purpose set. Internal-UI chrome icons (mask shapes / baked theme colours) are noted as not usable via icon:.

Clarify that icon: resolves to layered_ui/icon_NAME.svg and that an
unknown name raises Propshaft::MissingAssetError. List the icons that
ship with the gem (correcting the prior claim that only "home" did),
and add an Available icons section to the dummy app showing the
general-purpose set. Internal-UI chrome icons (mask shapes / baked
theme colours) are noted as not usable via icon:.
@claude

claude Bot commented Jun 7, 2026

Copy link
Copy Markdown

Review

Documentation-only PR that corrects and expands the icon reference: clarifies the behaviour, lists all icons that ship with the gem (previously just "home" was documented), distinguishes general-purpose from internal-chrome icons, and adds a visual Available icons section to the dummy app.

Verified: all 8 general-purpose icon names listed in HELPERS.md have corresponding icon_NAME.svg files in the gem. The dark:invert claim is accurate — .l-ui-navigation__item-icon carries that rule and .l-ui-icon does too, so the dummy app display will invert correctly. The internal-UI icons warned against (chevron_down, dark, etc.) are genuinely mask-based or carry baked colours, so the warning is correct.

No issues found.

Ship

@thomasgallagher
thomasgallagher merged commit 8a56468 into main Jun 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant