Issue2886 fan coil model#3124
Open
SenHuang19 wants to merge 125 commits intolbl-srg:issue2886_fanCoilModelfrom
Open
Issue2886 fan coil model#3124SenHuang19 wants to merge 125 commits intolbl-srg:issue2886_fanCoilModelfrom
SenHuang19 wants to merge 125 commits intolbl-srg:issue2886_fanCoilModelfrom
Conversation
PR to update branch with latest master
…nd process their results
… record with one that has updated UA calculations. Changed damper opening and zone mixing volume pressure to closely mirror EPlus values
…el to use X_input for zone volume. Added new model with no X_input for zone volume. Updated mos scripts for both files
…modelica-buildings into issue2886_fanCoilModel
Issue2886 fan coil model
…ca-buildings into SenHuang19-issue2886_fanCoilModel
Contributor
Author
|
@JayHuLBL can you please kindly review this PR? This PR is to address #2886 by adding a fan coil (four pipe) unit model. W essentially follow the system configurations from EnergyPlus but use existing component models from the Buildings Library to reimplement them. Validation and examples are provided. @karthikeyad-pnnl |
…ca-buildings into SenHuang19-issue2886_fanCoilModel
Issue2886 fan coil model
Member
|
@JayHuLBL @karthikeyad-pnnl Can you please let me know what the status is on this PR. What are the next steps, and by whom? |
Contributor
|
@mwetter This PR is dependent on the template for the zonal HVAC equipment. I am currently working on it, and will present and clear the template by you, before using it as a baseclass for the fan coil unit model here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.