Draft
Conversation
1cea147 to
49c0f67
Compare
c091e76 to
a02e08e
Compare
b623288 to
18f0bf1
Compare
9f02685 to
e73bafc
Compare
df84207 to
c41c984
Compare
4a1fa3f to
acc9086
Compare
…rg/modelica-buildings into issue1374_template_CHW_final
…/modelica-buildings into issue4152_HpTemplateWithModular
… and primary pump speed control
…roller_oct_2021' into issue2180_BoilerPlant_Nov23
…pnnl/modelica-buildings
…pnnl/modelica-buildings into issue2180_BoilerPlant_Nov23
…Nov23 Issue2180 boiler plant nov23
…ssue2180_BoilerPlant_MainController_oct_2021
…roller_oct_2021' into issue2180_BoilerPlant_Nov23
…ocumentation. Uncommented protected statement
…Nov23 Issue2180 boiler plant nov23
…b.com:lbl-srg/modelica-buildings
03ea1a9 to
2599460
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shall NOT be merged before #2700 is merged.
This will close #3266.
This is a DRAFT PR to test the new CI workflow for the Templates package (see
Buildings/Resources/Scripts/travis/templates/checkandrun.sh) and start the review process.TODO before merging:
issue2180_BoilerPlant_MainController_oct_2021is merged into the master, replaceTemplates.HeatingPlants.HotWater.Components.Controls.Guideline36Pluginwith the actual controller. (The branchissue3266_template_HW_planthas no dependency toissue2180_BoilerPlant_MainController_oct_2021and uses a "temporary" class that is plug compatible with the current version of the controller from commit 1a5959f.)Buildings/Resources/Scripts/travis/templates/BoilerPlant.pyand.travis.yml.finalin the binding offuefor records withinBuildings.Fluid.Boilers.Data.LochinvarDependencies
(*) This branch has several dependencies: see #3167