Skip to content

Templates • HW plant#3364

Draft
AntoineGautier wants to merge 2729 commits intomasterfrom
issue3266_template_HW_plant
Draft

Templates • HW plant#3364
AntoineGautier wants to merge 2729 commits intomasterfrom
issue3266_template_HW_plant

Conversation

@AntoineGautier
Copy link
Copy Markdown
Contributor

@AntoineGautier AntoineGautier commented Apr 28, 2023

This shall NOT be merged before #2700 is merged.
This will close #3266.
This is a DRAFT PR to test the new CI workflow for the Templates package (see Buildings/Resources/Scripts/travis/templates/checkandrun.sh) and start the review process.

TODO before merging:

  • Check that Issue2180 boiler plant main controller oct 2021 #2700 (review) are addressed, pull the changes once issue2180_BoilerPlant_MainController_oct_2021 is merged into the master, replace Templates.HeatingPlants.HotWater.Components.Controls.Guideline36Plugin with the actual controller. (The branch issue3266_template_HW_plant has no dependency to issue2180_BoilerPlant_MainController_oct_2021 and uses a "temporary" class that is plug compatible with the current version of the controller from commit 1a5959f.)
  • Restore all tests in Buildings/Resources/Scripts/travis/templates/BoilerPlant.py and .travis.yml.
  • Open issue to remove final in the binding of fue for records within Buildings.Fluid.Boilers.Data.Lochinvar

Dependencies

master
└── issue2293_chiller_plant_seq 
    └── issue1374_template_CHW_final (*)
    └── issue2180_BoilerPlant_MainController_oct_2021
        └── issue3266_template_HW_plant

(*) This branch has several dependencies: see #3167

@AntoineGautier AntoineGautier force-pushed the issue3266_template_HW_plant branch 5 times, most recently from 1cea147 to 49c0f67 Compare May 18, 2023 16:08
@AntoineGautier AntoineGautier force-pushed the issue3266_template_HW_plant branch from c091e76 to a02e08e Compare September 11, 2023 13:14
@AntoineGautier AntoineGautier force-pushed the issue3266_template_HW_plant branch from b623288 to 18f0bf1 Compare September 20, 2023 09:31
@AntoineGautier AntoineGautier changed the title HW plant template Templates • HW plant Sep 27, 2023
@AntoineGautier AntoineGautier force-pushed the issue3266_template_HW_plant branch from 9f02685 to e73bafc Compare February 12, 2025 15:12
@AntoineGautier AntoineGautier force-pushed the issue3266_template_HW_plant branch 5 times, most recently from df84207 to c41c984 Compare April 15, 2025 08:59
@AntoineGautier AntoineGautier force-pushed the issue3266_template_HW_plant branch from 4a1fa3f to acc9086 Compare April 18, 2025 12:46
karthikeyad-pnnl and others added 29 commits December 3, 2025 18:20
…roller_oct_2021' into issue2180_BoilerPlant_Nov23
…pnnl/modelica-buildings into issue2180_BoilerPlant_Nov23
…roller_oct_2021' into issue2180_BoilerPlant_Nov23
…ocumentation. Uncommented protected statement
@AntoineGautier AntoineGautier force-pushed the issue3266_template_HW_plant branch from 03ea1a9 to 2599460 Compare February 11, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Develop HW plant template

4 participants