Modify input connectors of modular heat pump models#4513
Merged
Conversation
…ssue4507_newInputConnectors
Contributor
Author
Member
|
@JayHuLBL : Can you please review this PR |
JayHuLBL
approved these changes
Mar 30, 2026
Contributor
JayHuLBL
left a comment
JayHuLBL
left a comment
There was a problem hiding this comment.
@AntoineGautier The changes look good to me, except one typo and few formating issues. I modified them and updated the checksum. Please check if it is good, otherwise, it is good to go.
Contributor
Author
Contributor
Author
|
@mwetter This is ready to merge. |
Member
|
@AntoineGautier : Can you please merge the change to |
Contributor
Author
|
@mwetter Good catch. This is done at ibpsa/modelica-ibpsa#2105 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #4507