Prevent endpoint rounding artefacts in accumulate#35
Draft
bcoltman wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the recent endpoint-clamping fix in
edit accumulateto handle an additional numerical edge case observed on zero-length branches.In some accumulated
.jplacefiles, placements on branches withbranch_length = 0.0could still be written with tiny non-zero coordinates (e.g.8.27e-25), which are subsequently rejected byguppy check/guppy fpd.The change clamps these machine-precision endpoint artefacts to the valid branch interval while leaving all biologically meaningful placement coordinates unchanged.