containers: mv produce_attestation to Validator

[tcoratger]

🗒️ Description

🔗 Related Issues or PRs

Part of #128

✅ Checklist

• Ran tox checks to avoid unnecessary CI fails:

  uvx tox

• Considered adding appropriate tests for the changes.
• Considered updating the online docs in the ./docs/ directory.

[KolbyML]

This PR feels weird, as the function is more dependent on Store, then it does to the validator_index.

Anyways I think this function should remain in Store, but instead of returning an Attestation, it returns AttestationData, then a validator_id/u64 isn't needed at all.

Then the function in Validator can construct the Attestation and take AttestationData as an argument.

I think this would achieve the goals of this PR, well removing the validator_id context as apart of Store

[tcoratger]

This PR feels weird, as the function is more dependent on Store, then it does to the validator_index.

Anyways I think this function should remain in Store, but instead of returning an Attestation, it returns AttestationData, then a validator_id/u64 isn't needed at all.

Then the function in Validator can construct the Attestation and take AttestationData as an argument.

I think this would achieve the goals of this PR, well removing the validator_id context as apart of Store

Just fixed, looks like a good idea, let me know what you think about it.

[KolbyML]

the PR looks a lot better,

^ my only concern is I am not sure if this was supposed to be commited, but other then that no concerns