forkchoice store: add _compute_lmd_ghost_head in core store - #190
Merged
Conversation
varun-doshi
reviewed
Nov 25, 2025
KolbyML
approved these changes
Nov 25, 2025
KolbyML
left a comment
KolbyML
left a comment
Contributor
There was a problem hiding this comment.
looks good, we did the same in Ream
2 tasks
unnawut
added
specs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
In my opinion it makes little sense to have this method in the helper file because this is the core of the logic and it relies on the blocks of the store, so it makes more sense to have this in the core of the store to maintain clarity.
🔗 Related Issues or PRs
✅ Checklist
toxchecks to avoid unnecessary CI fails:uvx tox