Skip to content

test: simplify validators initialization - #219

Merged
tcoratger merged 3 commits into
leanEthereum:mainfrom
unnawut:num-validators
Dec 4, 2025
Merged

test: simplify validators initialization#219
tcoratger merged 3 commits into
leanEthereum:mainfrom
unnawut:num-validators

Conversation

@unnawut

@unnawut unnawut commented Dec 4, 2025

Copy link
Copy Markdown
Collaborator

🗒️ Description

Now that we have validator key caching, I think we can get rid of the 2-step validator setup. i.e. instead of 1) creating validators with mock pubkeys at the test case level, then 2) generate and replace the mock pubkeys with actual ones at the base fixture level, we can simplify the test case to provide just num_validators and let the base fixture handle the key management.

This helps simplify the test setup and drops one more test-specific behavior (no more zerofill mock pubkeys for all test vectors). Also a cleaner base for creating test vectors that verify signatures.

This does not change the behavior of any existing test so no new tests added.

🔗 Related Issues or PRs

✅ Checklist

  • Ran tox checks to avoid unnecessary CI fails:
    uvx tox
  • Considered adding appropriate tests for the changes.
  • Considered updating the online docs in the ./docs/ directory.

@unnawut
unnawut requested a review from tcoratger December 4, 2025 08:23
@unnawut unnawut added the framework Scope: Changes to the testing framework label Dec 4, 2025

@tcoratger tcoratger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@tcoratger
tcoratger merged commit 6bfdbfc into leanEthereum:main Dec 4, 2025
10 checks passed
@unnawut
unnawut deleted the num-validators branch December 4, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework Scope: Changes to the testing framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants