Conversation
alszczep
requested review from
BeerHobbyist,
Komoszek,
kamilgacan,
katarzynagrasewicz,
konowrockis and
kumalg
as code owners
BeerHobbyist
approved these changes
Feb 10, 2026
konowrockis
reviewed
Feb 10, 2026
| /** | ||
| * Logger. Optional - only provide if you want to use a custom logger. | ||
| */ | ||
| logger?: ReturnType<typeof createJsonLogger> |
Member
There was a problem hiding this comment.
Shouldn't this type be named somewhere?
Contributor
Author
There was a problem hiding this comment.
I guess it would make sense for the logger package to expose types like this. Will do
konowrockis
reviewed
Feb 10, 2026
| return Promise.reject(e) | ||
| }) | ||
| ) | ||
| .then(result => { |
There was a problem hiding this comment.
Done! I've converted the promise chain in api.service.ts to async/await syntax. The changes include:
- Added
asynckeyword to therunmethod - Replaced
.then()and.catch()withtry/catchblock - Used
awaitfor thefirstValueFromcall - Changed
Promise.reject(e)tothrow e(more idiomatic for async/await)
The code is now cleaner and more readable. Changes have been committed and pushed to the logger branch.
konowrockis
approved these changes
Feb 10, 2026
Co-authored-by: Aleksander Szczepura <alszczep@users.noreply.github.com>
Co-authored-by: Aleksander Szczepura <alszczep@users.noreply.github.com>
Co-authored-by: Aleksander Szczepura <alszczep@users.noreply.github.com>
Co-authored-by: Aleksander Szczepura <alszczep@users.noreply.github.com>
Co-authored-by: Aleksander Szczepura <alszczep@users.noreply.github.com>
kumalg
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.