Add Local Updates - #49
Closed
suhr wants to merge 3 commits into
Closed
Conversation
Collaborator
|
Good catch, I don't actually think we do. Feel free to add them ( |
Contributor
Author
|
In Lemma alloc_option_local_update {A : cmra} (x : A) y :
✓ x →
(None, y) ~l~> (Some x, Some x).
Proof.
move=>Hx. apply local_update_unital=> n z _ /= Heq. split.
{ rewrite Some_validN. apply cmra_valid_validN. done. }
destruct z as [z|]; last done. destruct y; inversion Heq.
Qed.But in Lean, the proof turned out to be vacuous: theorem alloc_option_local_update {α : Type} [CMRA α]
{x : α} (y : α) (_: ✓ x): (none, y) ~l~> (some x, some x) :=
fun _ mz _ e =>
match mz with
| .none => False.elim e
| .some .none => False.elim e
| .some (.some _) => False.elim eThat's sus, is the instance of |
suhr
marked this pull request as ready for review
June 23, 2025 11:51
Contributor
Author
|
Fixed this, and now the PR is ready for review. |
Closed
Collaborator
|
Nice work! Mario is too busy to review and merge PR's right now but if you wanted to do more, #58 should be very accessible to you. |
Closed
Closed
Closed
Collaborator
|
See: #70 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #27. Uses #66.
Do we have CMRAs for
Unitand products?