Skip to content

feat: port modality_embed_mixin and IntoEmbed - #538

Merged
MackieLoeffel merged 7 commits into
leanprover-community:masterfrom
ISTA-PLV:ModalityEmbed
Jul 27, 2026
Merged

feat: port modality_embed_mixin and IntoEmbed#538
MackieLoeffel merged 7 commits into
leanprover-community:masterfrom
ISTA-PLV:ModalityEmbed

Conversation

@alvinylt

Copy link
Copy Markdown
Contributor

Description

Addresses #225 in full. Also addresses #219 and #235 in part.

  • Modified FromModal so that it is on the same level of generality as the Rocq version. Adjusted the implementation of imodintro to accommodate the generalisation.
  • Ported the type class IntoEmbed.
  • Ported the two instances of IntoEmbed along with a new instance of FromModal.
  • Ported modality_embed and modality_embed_mixin.
  • Some relevant tests with imodintro.

Other Changes

Added the missing unpackIprop for Embed so that the iprop(...) wrapper does not get printed in the proof state.

Checklist

  • My code follows the mathlib naming and code style conventions
  • I have added my name to the authors section of any appropriate files

@MackieLoeffel

Copy link
Copy Markdown
Collaborator

Looks great, thanks!

@MackieLoeffel
MackieLoeffel merged commit 73579ba into leanprover-community:master Jul 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants