feat: port all missing theorems in BI/DerivedLaws.lean and BI/DerivedLawsLater.lean - #539
Conversation
`limitPreserving_emp_valid`
|
I did a pass just on GitHub. If you are too time-constrained right now with proofmode changes, I can also make the fixes, but otherwise I think it is good to get some practice making these basic refactoring changes to match our idioms. |
|
Please find the fixes addressing the review comments in the latest commits. There are also many existing proofs that could be better presented in Once the remaining PRs for the IPM tactics are merged, I plan to go through the entire |
|
Great work, thank you! Yes, I agree that there are quite a few places in the repo which should get a second look--usually I think this happens when reviewers are overwhelmed, at least that's where some of my lax reviews have came from in the past. Either way, I think that documenting style problems eagerly is a good way to make future reviews (and reviewers :p) more efficient. |
b6d0b68
into
leanprover-community:master
Description
Port all missing theorems and instances in
BI/DerivedLaws.leanandBI/DerivedLawsLater.lean.Checklist of theorems and instances being ported
bi.and_parallelbi.bi_or_monoidbi.decide_bi_Truebi.decide_empbi.entails_anti_sym(already exists, added missingrocq_aliasannotation)bi.entails_implbi.equiv_entails_2(ignored, theBiEntailsconstructor) can be used directly)bi.equiv_iffbi.exist_wand_forallbi.from_option_persistentbi.iff_equivbi.iff_symbi.iff_transbi.impl_altbi.impl_entailsbi.impl_wandbi.impl_wand_2bi.impl_wand_intuitionisticallybi.intuitionistically_alt_fixpointbi.intuitionistically_introbi.limit_preserving_emp_validbi.persistent_absorbingly_affinelybi.persistent_and_sep_assocbi.persistent_impl_wand_affinelybi.persistent_sep_dupbi.persistent_sep_dup_1bi.pure_flip_mono(ignored, specific to thePropertype class in Rocq)bi.pure_impl_forallbi.pure_wand_forallbi.wand_iff_symbi.wand_iff_transbi.laterN_iter(ignored,laterNin Lean is itself defined usingNat.repeat, Convert LaterN to use Nat.repeat instead of recursion #324)bi.löb_alt_wandbi.not_not_later_FalseThe theorem
bi.wandM_soundis ported in #470.Checklist
authorssection of any appropriate files